From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: [BK PATCHES] 2.6.x misc updates
Date: Mon, 27 Dec 2004 15:15:14 -0500 [thread overview]
Message-ID: <41D06D52.6090902@pobox.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 0 bytes --]
[-- Attachment #2: changelog.txt --]
[-- Type: text/plain, Size: 712 bytes --]
Please do a
bk pull bk://gkernel.bkbits.net/misc-2.6
This will update the following files:
drivers/block/floppy.c | 1 -
drivers/char/hw_random.c | 35 ++++++++++++++++-------------------
sound/oss/i810_audio.c | 12 ++++++------
sound/oss/soundcard.c | 4 ++--
sound/oss/uart401.c | 8 ++++----
5 files changed, 28 insertions(+), 32 deletions(-)
through these ChangeSets:
Adrian Bunk:
o drivers/char/hw_random.c: make a variable static
James Nelson:
o hw_random: Minor cleanup to hw_random.c
Jeff Garzik:
o drivers/block/floppy: kill #include linux/version.h
o [sound/oss] use module_param() in soundcard.c and uart401.c
o [sound/oss i810_audio] use module_param()
[-- Attachment #3: patch.txt --]
[-- Type: text/plain, Size: 4499 bytes --]
diff -Nru a/drivers/block/floppy.c b/drivers/block/floppy.c
--- a/drivers/block/floppy.c 2004-12-27 15:14:25 -05:00
+++ b/drivers/block/floppy.c 2004-12-27 15:14:25 -05:00
@@ -155,7 +155,6 @@
#include <linux/kernel.h>
#include <linux/timer.h>
#include <linux/workqueue.h>
-#include <linux/version.h>
#define FDPATCHES
#include <linux/fdreg.h>
diff -Nru a/drivers/char/hw_random.c b/drivers/char/hw_random.c
--- a/drivers/char/hw_random.c 2004-12-27 15:14:25 -05:00
+++ b/drivers/char/hw_random.c 2004-12-27 15:14:25 -05:00
@@ -56,31 +56,27 @@
/*
* debugging macros
*/
-#undef RNG_DEBUG /* define to enable copious debugging info */
-#ifdef RNG_DEBUG
-/* note: prints function name for you */
-#define DPRINTK(fmt, args...) printk(KERN_DEBUG "%s: " fmt, __FUNCTION__ , ## args)
-#else
-#define DPRINTK(fmt, args...)
-#endif
+/* pr_debug() collapses to a no-op if DEBUG is not defined */
+#define DPRINTK(fmt, args...) pr_debug(PFX "%s: " fmt, __FUNCTION__ , ## args)
+
-#define RNG_NDEBUG /* define to disable lightweight runtime checks */
+#undef RNG_NDEBUG /* define to enable lightweight runtime checks */
#ifdef RNG_NDEBUG
-#define assert(expr)
+#define assert(expr) \
+ if(!(expr)) { \
+ printk(KERN_DEBUG PFX "Assertion failed! %s,%s,%s," \
+ "line=%d\n", #expr, __FILE__, __FUNCTION__, __LINE__); \
+ }
#else
-#define assert(expr) \
- if(!(expr)) { \
- printk( "Assertion failed! %s,%s,%s,line=%d\n", \
- #expr,__FILE__,__FUNCTION__,__LINE__); \
- }
+#define assert(expr)
#endif
#define RNG_MISCDEV_MINOR 183 /* official */
static int rng_dev_open (struct inode *inode, struct file *filp);
static ssize_t rng_dev_read (struct file *filp, char __user *buf, size_t size,
- loff_t * offp);
+ loff_t * offp);
static int __init intel_init (struct pci_dev *dev);
static void intel_cleanup(void);
@@ -322,7 +318,8 @@
rnen |= (1 << 7); /* PMIO enable */
pci_write_config_byte(dev, 0x41, rnen);
- printk(KERN_INFO PFX "AMD768 system management I/O registers at 0x%X.\n", pmbase);
+ pr_info( PFX "AMD768 system management I/O registers at 0x%X.\n",
+ pmbase);
amd_dev = dev;
@@ -369,7 +366,7 @@
VIA_RNG_CHUNK_1_MASK = 0xFF,
};
-u32 via_rng_datum;
+static u32 via_rng_datum;
/*
* Investigate using the 'rep' prefix to obtain 32 bits of random data
@@ -483,7 +480,7 @@
static ssize_t rng_dev_read (struct file *filp, char __user *buf, size_t size,
- loff_t * offp)
+ loff_t * offp)
{
static spinlock_t rng_lock = SPIN_LOCK_UNLOCKED;
unsigned int have_data;
@@ -606,7 +603,7 @@
if (rc)
return rc;
- printk (KERN_INFO RNG_DRIVER_NAME " loaded\n");
+ pr_info( RNG_DRIVER_NAME " loaded\n");
DPRINTK ("EXIT, returning 0\n");
return 0;
diff -Nru a/sound/oss/i810_audio.c b/sound/oss/i810_audio.c
--- a/sound/oss/i810_audio.c 2004-12-27 15:14:25 -05:00
+++ b/sound/oss/i810_audio.c 2004-12-27 15:14:25 -05:00
@@ -3460,15 +3460,15 @@
}
#endif /* CONFIG_PM */
-MODULE_AUTHOR("");
+MODULE_AUTHOR("The Linux kernel team");
MODULE_DESCRIPTION("Intel 810 audio support");
MODULE_LICENSE("GPL");
-MODULE_PARM(ftsodell, "i");
-MODULE_PARM(clocking, "i");
-MODULE_PARM(strict_clocking, "i");
-MODULE_PARM(spdif_locked, "i");
+module_param(ftsodell, int, 0444);
+module_param(clocking, uint, 0444);
+module_param(strict_clocking, int, 0444);
+module_param(spdif_locked, int, 0444);
-#define I810_MODULE_NAME "intel810_audio"
+#define I810_MODULE_NAME "i810_audio"
static struct pci_driver i810_pci_driver = {
.name = I810_MODULE_NAME,
diff -Nru a/sound/oss/soundcard.c b/sound/oss/soundcard.c
--- a/sound/oss/soundcard.c 2004-12-27 15:14:25 -05:00
+++ b/sound/oss/soundcard.c 2004-12-27 15:14:25 -05:00
@@ -535,8 +535,8 @@
static int dmabuf;
static int dmabug;
-MODULE_PARM(dmabuf, "i");
-MODULE_PARM(dmabug, "i");
+module_param(dmabuf, int, 0444);
+module_param(dmabug, int, 0444);
static int __init oss_init(void)
{
diff -Nru a/sound/oss/uart401.c b/sound/oss/uart401.c
--- a/sound/oss/uart401.c 2004-12-27 15:14:25 -05:00
+++ b/sound/oss/uart401.c 2004-12-27 15:14:25 -05:00
@@ -430,11 +430,11 @@
static struct address_info cfg_mpu;
-static int __initdata io = -1;
-static int __initdata irq = -1;
+static int io = -1;
+static int irq = -1;
-MODULE_PARM(io, "i");
-MODULE_PARM(irq, "i");
+module_param(io, int, 0444);
+module_param(irq, int, 0444);
static int __init init_uart401(void)
next reply other threads:[~2004-12-27 20:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-27 20:15 Jeff Garzik [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-11-13 20:54 [BK PATCHES] 2.6.x misc updates Jeff Garzik
2003-09-28 14:44 [bk patches] " Jeff Garzik
2003-09-28 16:40 ` Dave Jones
2003-09-28 17:02 ` Jeff Garzik
2003-09-28 17:38 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41D06D52.6090902@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.