From: ramana <ramana@intraperson.com>
To: autofs@linux.kernel.org
Subject: unacceptable bug in autofs kernel module
Date: Tue, 28 Dec 2004 13:21:08 +0530 [thread overview]
Message-ID: <41D1106C.9070706@intraperson.com> (raw)
Dear developers,
Here is the bug in autofs3 module which causing so much pain. It simply
stopped me from adding much more interesting features to Autodir
http://www.intraperson.com/autodir/
Taken from Linux kernel 2.4 autofs module source.
file: root.c
function: autofs_root_lookup.
protocol: 3
/*
* If this dentry is unhashed, then we shouldn't honour this
* lookup even if the dentry is positive. Returning ENOENT here
* doesn't do the right thing for all system calls, but it should
* be OK for the operations we permit from an autofs.
*/
/*
if ( dentry->d_inode && d_unhashed(dentry) )
return ERR_PTR(-ENOENT);
*/
if ( dentry->d_inode && d_unhashed(dentry) ) {
printk( "ENOENT for %s\n", dentry->d_name.name );
return ERR_PTR(-ENOENT);
}
I added printk to easily trace it. To my surprise autofs 4 also has
similar code.
Because of this, user space test program reporting like this:
fail : /test/t944 : No such file or directory
fail : /test/t4187 : No such file or directory
fail : /test/t100 : No such file or directory
fail : /test/t806 : No such file or directory
fail : /test/t3451 : No such file or directory
fail : /test/t1790 : No such file or directory
fail : /test/t3555 : No such file or directory
fail : /test/t3098 : No such file or directory
fail : /test/t4085 : No such file or directory
fail : /test/t3935 : No such file or directory
with corresponding kernel messages are,
ENOENT for t944
ENOENT for t4187
ENOENT for t100
ENOENT for t806
ENOENT for t3451
ENOENT for t1790
ENOENT for t3555
ENOENT for t3098
ENOENT for t4085
ENOENT for t3935
The error rate as taken from months of stress tests -- ie ENOENT; is
around 0.002% and increases as system load increases. Even at this rate
I do not think it is acceptable in production systems.
Thanks in advance.
Regards
ramana
--
http://www.intraperson.com
next reply other threads:[~2004-12-28 7:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-28 7:51 ramana [this message]
2004-12-29 1:02 ` unacceptable bug in autofs kernel module Ian Kent
2004-12-29 3:44 ` ramana
[not found] ` <41D21C1E.8040407@intraperson.com>
[not found] ` <Pine.LNX.4.58.0412291418160.8463@wombat.indigo.net.au>
[not found] ` <41D28271.601@intraperson.com>
2004-12-30 0:38 ` Ian Kent
2004-12-30 0:47 ` Ian Kent
[not found] ` <41D370E7.9080409@intraperson.com>
2004-12-30 5:42 ` Ian Kent
2005-02-04 0:38 ` mmarion
2005-02-04 1:49 ` Ian Kent
2005-02-04 2:59 ` ramana
2005-02-05 13:46 ` ramana
-- strict thread matches above, loose matches on Subject: below --
2005-02-04 18:58 peter.a.harris
2005-03-07 19:49 ` Mike Marion
2005-02-04 19:11 Lever, Charles
2005-02-04 22:34 peter.a.harris
2005-02-25 21:22 Trinh, Ngan
2005-03-08 0:16 peter.a.harris
2005-03-08 22:53 ` Mike Marion
2005-03-21 20:54 devnull
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41D1106C.9070706@intraperson.com \
--to=ramana@intraperson.com \
--cc=autofs@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.