All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [3/8] kill gen_init_cpio.c printk() of size_t warning
Date: Mon, 03 Jan 2005 12:59:55 -0500	[thread overview]
Message-ID: <41D9881B.4020000@pobox.com> (raw)
In-Reply-To: <20050103172839.GE29332@holomorphy.com>

William Lee Irwin III wrote:
> The rest of gen_init_cpio.c seems to cast the result of strlen() to
> handle this situation, so this patch follows suit while killing off
> size_t -related printk() warnings.
> 
> Signed-off-by: William Irwin <wli@holomorphy.com>
> 
> Index: mm1-2.6.10/usr/gen_init_cpio.c
> ===================================================================
> --- mm1-2.6.10.orig/usr/gen_init_cpio.c	2005-01-03 06:45:53.000000000 -0800
> +++ mm1-2.6.10/usr/gen_init_cpio.c	2005-01-03 08:11:18.000000000 -0800
> @@ -86,7 +86,7 @@
>  		0,			/* minor */
>  		0,			/* rmajor */
>  		0,			/* rminor */
> -		(unsigned)strlen(name) + 1, /* namesize */
> +		(unsigned)strlen(name)+1, /* namesize */
>  		0);			/* chksum */
>  	push_hdr(s);
>  	push_rest(name);
> @@ -112,7 +112,7 @@
>  		(long) gid,		/* gid */
>  		1,			/* nlink */
>  		(long) mtime,		/* mtime */
> -		strlen(target) + 1,	/* filesize */
> +		(unsigned)strlen(target)+1, /* filesize */

This removes whitespace in the process, violating the file's chosen 
style (and typical lkml style).

	Jeff




  parent reply	other threads:[~2005-01-03 18:01 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-03 17:20 [0/8] patches vs. 2.6.10-mm1 William Lee Irwin III
2005-01-03 17:23 ` [1/8] there is no generic_file_(get|set)_policy() William Lee Irwin III
2005-01-03 17:26   ` [2/8] kill quota_v2.c printk() of size_t warning William Lee Irwin III
2005-01-03 17:28     ` [3/8] kill gen_init_cpio.c " William Lee Irwin III
2005-01-03 17:31       ` [4/8] fix arch/x86_64/ia32/syscall32.c misdeclared pud variable William Lee Irwin III
2005-01-03 17:34       ` William Lee Irwin III
2005-01-03 17:36         ` [5/8] silence numerous size_t warnings in drivers/acpi/processor_idle.c William Lee Irwin III
2005-01-03 17:39           ` [6/8] make IRDA string tables conditional on CONFIG_IRDA_DEBUG William Lee Irwin III
2005-01-03 17:45             ` [7/8] fix unresolved MTD symbols in scx200_docflash.c William Lee Irwin III
2005-01-03 17:47               ` [8/8] fix module_param() type mismatch in drivers/char/n_hdlc.c William Lee Irwin III
2005-01-03 18:11                 ` William Lee Irwin III
2005-01-03 17:42       ` [3/8] kill gen_init_cpio.c printk() of size_t warning linux-os
2005-01-03 17:59       ` Jeff Garzik [this message]
2005-01-03 18:09         ` William Lee Irwin III
2005-01-03 18:33           ` linux-os
2005-01-03 21:09             ` H. Peter Anvin
2005-01-03 21:36               ` William Lee Irwin III
2005-01-03 21:41                 ` H. Peter Anvin
2005-01-03 22:03                   ` linux-os
2005-01-03 21:55                 ` Al Viro
2005-01-03 22:09                   ` William Lee Irwin III
2005-01-03 23:03                   ` Ben Pfaff
2005-01-03 23:56                     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41D9881B.4020000@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wli@holomorphy.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.