All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Bouliane <nib@cookinglinux.org>
To: netfilter-devel <netfilter-devel@lists.netfilter.org>
Subject: [PATCH] ip_conntrack_ftp segfault
Date: Mon, 03 Jan 2005 14:22:19 -0500	[thread overview]
Message-ID: <41D99B6B.6050601@cookinglinux.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]


Hi,

This patch fix two bugs (when DEBUGP is defined):
o The var `data` doesn't exist, hence gcc complains.
o It segfault because we print an integer with `%s`.

Cheers! :)

-acidfu

[-- Attachment #2: ip_conntrack_ftp.c.patch --]
[-- Type: text/x-patch, Size: 558 bytes --]

--- /usr/src/old/linux-2.6.10/net/ipv4/netfilter/ip_conntrack_ftp.c	2004-12-24 16:35:59.000000000 -0500
+++ ip_conntrack_ftp.c	2005-01-03 14:09:06.000000000 -0500
@@ -347,9 +347,8 @@
 		goto out;
 	}
 
-	DEBUGP("conntrack_ftp: match `%.*s' (%u bytes at %u)\n",
-	       (int)matchlen, data + matchoff,
-	       matchlen, ntohl(th->seq) + matchoff);
+	DEBUGP("conntrack_ftp: match `%s' (%u bytes at %u)\n",
+			search[i].pattern, matchlen, ntohl(th->seq) + matchoff);
 
 	/* Allocate expectation which will be inserted */
 	exp = ip_conntrack_expect_alloc();

             reply	other threads:[~2005-01-03 19:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-03 19:22 Nicolas Bouliane [this message]
2005-01-04 10:35 ` [PATCH] ip_conntrack_ftp segfault Pablo Neira
2005-01-04 18:45   ` Nicolas Bouliane
2005-02-01 13:24     ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41D99B6B.6050601@cookinglinux.org \
    --to=nib@cookinglinux.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.