From: Nick Piggin <nickpiggin@yahoo.com.au>
To: David Howells <dhowells@redhat.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Exclude PUD/PMD alloc functions if !MMU
Date: Wed, 05 Jan 2005 13:15:08 +1100 [thread overview]
Message-ID: <41DB4DAC.8060606@yahoo.com.au> (raw)
In-Reply-To: <17892.1104868588@redhat.com>
David Howells wrote:
> Don't declare pud_alloc() and pmd_alloc() if a nommu kernel is being
> compiled. These functions require various things that aren't defined for
> nommu.
>
> Signed-Off-By: David Howells <dhowells@redhat.com>
> ---
> warthog>diffstat nommu-exclusions-2610mm1.diff
> mm.h | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -uNrp /warthog/kernels/linux-2.6.10-mm1/include/linux/mm.h linux-2.6.10-mm1-frv/include/linux/mm.h
> --- /warthog/kernels/linux-2.6.10-mm1/include/linux/mm.h 2005-01-04 11:15:27.000000000 +0000
> +++ linux-2.6.10-mm1-frv/include/linux/mm.h 2005-01-04 17:39:56.462745022 +0000
> @@ -668,7 +668,7 @@ extern void remove_shrinker(struct shrin
> * The following ifdef needed to get the 4level-fixup.h header to work.
> * Remove it when 4level-fixup.h has been removed.
> */
> -#ifndef __ARCH_HAS_4LEVEL_HACK
> +#if defined(CONFIG_MMU) && !defined(__ARCH_HAS_4LEVEL_HACK)
> static inline pud_t *pud_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address)
> {
> if (pgd_none(*pgd))
I think you need to do it in the following way:
#ifdef CONFIG_MMU
#ifndef __ARCH_HAS_4LEVEL_HACK
static inline pud_t *pud_alloc(struct mm_struct *mm, pgd_t *pgd, unsigned long address)
{
if (pgd_none(*pgd))
...
#else /* __ARCH_HAS_4LEVEL_HACK */
...
#endif /* __ARCH_HAS_4LEVEL_HACK */
#endif /* CONFIG_MMU */
No?
next prev parent reply other threads:[~2005-01-05 2:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-04 19:56 [PATCH] Exclude PUD/PMD alloc functions if !MMU David Howells
2005-01-05 2:15 ` Nick Piggin [this message]
2005-01-05 11:45 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41DB4DAC.8060606@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.