From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Dickson Subject: Re: [PATCH] -o intr mount option prevents core dumps on 2.4 kernel Date: Tue, 11 Jan 2005 14:36:55 -0500 Message-ID: <41E42AD7.3030303@RedHat.com> References: <41DD8403.7030601@RedHat.com> <1105118040.10979.70.camel@lade.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Cc: nfs@lists.sourceforge.net Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.12] helo=sc8-sf-mx2.sourceforge.net) by sc8-sf-list2.sourceforge.net with esmtp (Exim 4.30) id 1CoRlm-0006Kx-6l for nfs@lists.sourceforge.net; Tue, 11 Jan 2005 11:33:34 -0800 Received: from mx1.redhat.com ([66.187.233.31]) by sc8-sf-mx2.sourceforge.net with esmtp (TLSv1:AES256-SHA:256) (Exim 4.41) id 1CoRlj-0004VB-ON for nfs@lists.sourceforge.net; Tue, 11 Jan 2005 11:33:34 -0800 To: Trond Myklebust In-Reply-To: <1105118040.10979.70.camel@lade.trondhjem.org> Sender: nfs-admin@lists.sourceforge.net Errors-To: nfs-admin@lists.sourceforge.net List-Unsubscribe: , List-Id: Discussion of NFS under Linux development, interoperability, and testing. List-Post: List-Help: List-Subscribe: , List-Archive: Trond Myklebust wrote: >to den 06.01.2005 Klokka 13:31 (-0500) skreiv Steve Dickson: > > > >>Comments... Suggestions... Crimes against humanity that I'm committing??? >> >> > > >Firstly, how is "cl_intr" preventing core dumps? Normally, we should be >masking all signals except SIGKILL, SIGINT and SIGQUIT. I can see that >masking SIGINT and SIGQUIT might be useful here, but not SIGKILL... > > Because __rpc_execute() notices that signalled() is set and aborts the write by returning -ERESTARTSYS makes the core dumping code stop dumping. >Secondly: Why not do all this in rpc_clnt_sigmask()? > > I looked at that.... but I really was not sure if could hack it up to turn off signalled() and plus I was sure how I could turn signalled() back on at the end of the write.... The way I did just seemed less risky and seem to work... steved. ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs