Re: [PATCH] -o intr mount option prevents core dumps on 2.4 kernel

[Steve Dickson <SteveD@redhat.com>]

Trond Myklebust wrote:

>===================================================================
>--- linux-2.4.28-rc1.orig/net/sunrpc/clnt.c
>+++ linux-2.4.28-rc1/net/sunrpc/clnt.c
>@@ -209,7 +209,7 @@ void rpc_clnt_sigmask(struct rpc_clnt *c
> 	unsigned long	irqflags;
> 	
> 	/* Turn off various signals */
>-	if (clnt->cl_intr) {
>+	if (clnt->cl_intr && !(current->flags & PF_DUMPCORE)) {
> 		struct k_sigaction *action = current->sig->action;
> 		if (action[SIGINT-1].sa.sa_handler == SIG_DFL)
> 			sigallow |= sigmask(SIGINT);
>  
>
Well did you try  just this? ;-)

Here is what I found.... just adding the PF_DUMPCORE rpc_clnt_sigmask() 
no core was dropped
because __rpc_execute returned -ERESTARTSYS due to signalled() == TRUE.

When I added back the  PF_DUMPCORE check to __rpc_execute(), only the 
header of the core
was dropped  because nfs_wait_event() returned -ERESTARTSYS because 
signalled() == TRUE.

When I added back the PF_DUMPCORE to nfs_wait_event(), the entire core 
was dropped.

So it appears to me that you need both checks.....

steved



-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs