All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: zhongyu <xxx@mail.goldenhope.com.cn>
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: a patch for conntrack_tuple
Date: Fri, 14 Jan 2005 05:03:11 +0100	[thread overview]
Message-ID: <41E7447F.5060400@trash.net> (raw)
In-Reply-To: <BF65C818-65DF-11D9-9545-000A95B170F8@mail.goldenhope.com.cn>

zhongyu wrote:

> --- include/linux/netfilter_ipv4/ip_conntrack_tuple.h   27 Nov 2003 
> 12:42:40 -0000      1.2
> +++ include/linux/netfilter_ipv4/ip_conntrack_tuple.h   10 Jan 2005 
> 04:28:28 -0000
> @@ -50,13 +50,37 @@
>                         u_int64_t all;
>
> [...] 

> The function hash_conntrack use the low 16 bits of tuple->dst, but in 
> big-endian system
> the port infomation is in high 16 bits. So the destination port on 
> big-endian system was
> ignored. This caused hash collision. The patch above fixed this 
> problem :-)


In the mainline kernel "all" is u_int16_t. Have you applied any patches ?

Regards
Patrick

      reply	other threads:[~2005-01-14  4:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050111102202.99FD6A90F2@mail.goldenhope.com.cn>
2005-01-14  3:52 ` a patch for conntrack_tuple zhongyu
2005-01-14  4:03   ` Patrick McHardy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41E7447F.5060400@trash.net \
    --to=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=xxx@mail.goldenhope.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.