From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Randy.Dunlap" Date: Sun, 16 Jan 2005 19:25:57 +0000 Subject: [KJ] Re: [PATCH 0/13] remove cli()/sti() in drivers/char/* Message-Id: <41EABFC5.3060002@osdl.org> List-Id: References: <20050116135223.30109.26479.55757@localhost.localdomain> In-Reply-To: <20050116135223.30109.26479.55757@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: James Nelson Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org, akpm@osdl.org James Nelson wrote: > This series of patches removes the last cli()/sti()/save_flags()/restore_flags() > function calls in drivers/char. to what end? I guess I don't get it. What makes these drivers SMP-safe now? Or is this series of patches only done to kill off the use of deprecated functions? If that's the case, they could easily give someone the (false) expectation that the drivers are SMP-safe, couldn't they? Well, ftape (for one) is still marked as BROKEN_ON_SMP, but will people know why it's marked that way? Have you read Documentation/cli-sti-removal.txt ? -- ~Randy _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org http://lists.osdl.org/mailman/listinfo/kernel-janitors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262555AbVAPTdZ (ORCPT ); Sun, 16 Jan 2005 14:33:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262562AbVAPTdZ (ORCPT ); Sun, 16 Jan 2005 14:33:25 -0500 Received: from fire.osdl.org ([65.172.181.4]:15064 "EHLO fire-1.osdl.org") by vger.kernel.org with ESMTP id S262555AbVAPTdW (ORCPT ); Sun, 16 Jan 2005 14:33:22 -0500 Message-ID: <41EABFC5.3060002@osdl.org> Date: Sun, 16 Jan 2005 11:25:57 -0800 From: "Randy.Dunlap" User-Agent: Mozilla Thunderbird 0.9 (X11/20041103) X-Accept-Language: en-us, en MIME-Version: 1.0 To: James Nelson CC: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org, akpm@osdl.org Subject: Re: [PATCH 0/13] remove cli()/sti() in drivers/char/* References: <20050116135223.30109.26479.55757@localhost.localdomain> In-Reply-To: <20050116135223.30109.26479.55757@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org James Nelson wrote: > This series of patches removes the last cli()/sti()/save_flags()/restore_flags() > function calls in drivers/char. to what end? I guess I don't get it. What makes these drivers SMP-safe now? Or is this series of patches only done to kill off the use of deprecated functions? If that's the case, they could easily give someone the (false) expectation that the drivers are SMP-safe, couldn't they? Well, ftape (for one) is still marked as BROKEN_ON_SMP, but will people know why it's marked that way? Have you read Documentation/cli-sti-removal.txt ? -- ~Randy