Re: [PATCH 2/2] Remove input_call_hotplug

[Hannes Reinecke <hare@suse.de>]

Dmitry Torokhov wrote:
> Hi Hannes, 
> 
> On Wed, 19 Jan 2005 10:59:30 +0100, Hannes Reinecke <hare@suse.de> wrote:
> 
>>Dmitry Torokhov wrote:
>>
>>>But the real question is whether we really need class devices have
>>>unique names or we could do with inputX thus leaving individual
>>>drivers intact and only modifying the input core. As far as I
>>>understand userspace should be concerned only with device
>>>capabilities, not particular name, besides, it gets PRODUCT string
>>>which has all needed data encoded.
>>>
>>
>>Indeed. What about using 'phys' (with all '/' replaced by '-') as the
>>class_id? This way we'll retain compability with /proc/bus/input/devices
>>and do not have to touch every single driver.
>>
> 
> 
> I want to kill phys at some point - we have topology information
> already present in sysfs in much better form. Can we have a new
> hotplug variable HWDEV= which is kobject_path(input_dev->dev). If
> input_dev is not set then we can just dump phys in it. And the class
> id will still be inputX. Will this work?
>  
Sure. And we don't need a special HWDEV variable, as there is already a 
PHYSDEVPATH variable providing exactly this information.
I'm not too happy about this 'inputX' thing (as this doesn't carry any 
information, whereas 'phys' gives you at least a rough guess what this 
device's about), but if phys is to go it would be the logical choice.

> Btw, I really doubt that topology information is important here as the
> only thing that one needs to do when new "input_device" appears is to
> load one or more input handler modules based on device's capability
> bits. The decision whether a device is "good enough" to create a
> device node should be done by hotplug handler for the other "input"
> class.
> 
Yes, topology is not an issue when loading modules.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux AG				S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de