Dmitry Torokhov wrote: > On Wed, 19 Jan 2005 15:16:08 +0100, Hannes Reinecke wrote: > [ ... ] >>I'm not too happy about this 'inputX' thing (as this doesn't carry any >>information, whereas 'phys' gives you at least a rough guess what this >>device's about), but if phys is to go it would be the logical choice. >> > > > The problem with encoding phys in class ID is the following: you have > to guarantee that the moment you destroy underlying hw device yur > input_device has to be gone too. Imagine you have input_device for > your PS/2 mouse and you decide to unload psmouse module. You also have > one of user processes holding any of the class device attributes open. > This causes input_device to be pinned into memory so when you load > psmouse module back again it will not be able to create new > input_device and mouse will be dead. With monotonicaly increasing > inputX name you will never have this issue. > oops. hadn't thought of that. But of course, you are correct. So better be using monotonically increasing numbers. New patch attached. Cheers, Hannes -- Dr. Hannes Reinecke hare@suse.de SuSE Linux AG S390 & zSeries Maxfeldstraße 5 +49 911 74053 688 90409 Nürnberg http://www.suse.de