append-only attribute support

["Aaron D. Ball" <adb@bdi.com>]

knfsd as of Linux 2.6.10 refuses to have anything to do with files or 
directories with the append-only attribute set:  not even read 
operations are allowed.  While I understand that NFS doesn't support the 
idea of appending to files, it seems like there should at least be read 
and mkdir support for append-only files and directories, and that this 
could be implemented with a couple small changes to the logic of 
fs/nfsd/vfs.c.

Does that seem reasonable?  Is it likely to happen soon?  Should I try 
to work up a patch?

Though I haven't tested this, it looks like a one-line fix at first glance:

--- vfs.c~      2004-12-24 16:34:31.000000000 -0500
+++ vfs.c       2005-01-21 12:52:14.000000000 -0500
@@ -658,7 +658,7 @@
         * with mandatory locking enabled
         */
        err = nfserr_perm;
-       if (IS_APPEND(inode) || IS_ISMNDLK(inode))
+       if ((IS_APPEND(inode) || (access & MAY_WRITE)) || 
IS_ISMNDLK(inode))
                goto out;
        if (!inode->i_fop)
                goto out;



-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs