[uml-devel] skas3 patch breaks ATI video drivers

[Marcus Better <marcus@better.se>]

Hi all,

I applied Blaisorblade's host-skas3-2.6.9-v7.patch, and it breaks the 
fglrx graphics driver from ATI[1]. This is with Debian kernel 2.6.9, but 
I believe it applies to vanilla kernels also.

The problem is the following declaration added to include/asm-i386/desc.h:

----------------------------------------------------------
extern int modify_ldt(struct mm_struct * mm, int func, void __user *ptr,
		      unsigned long bytecount);
----------------------------------------------------------

The fglrx driver contains the following macro in a source file:

_syscall3( int, modify_ldt, int, func, void *, ptr, unsigned long, 
bytecount )

Here the compiler chokes with the following error:
---------------------------------------------------------
/usr/src/modules/fglrx-4.3.0-3.14.6/firegl_public.c:181: error: 
conflicting types for `modify_ldt'
include/asm/desc.h:144: error: previous declaration of `modify_ldt'
---------------------------------------------------------

I don't understand the details of the kernel code, but it seems that the 
problem is that the SKAS patch defines the function modify_ldt which 
conflicts with the syscall macros.

I renamed the new function to _modify_ldt instead (and changed the two 
or three references to it in ldt.c), and this seems to fix the problem.

Please CC replies to me, I'm not subscribed to the list.

Thanks for your work!

Marcus B.

[1] http://www.ati.com/support/drivers/linux/radeon-linux.html




-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel