All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kernel/configs.c: make a variable static
Date: Tue, 25 Jan 2005 13:56:10 -0800	[thread overview]
Message-ID: <41F6C07A.5010609@osdl.org> (raw)
In-Reply-To: <20050121100737.GA3209@stusta.de>

Adrian Bunk wrote:
> This patch makes a needlessly global variable static.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Acked-by: Randy Dunlap <rddunlap@osdl.org>

> ---
> 
> This patch was already sent on:
> - 12 Dec 2004
> 
> --- linux-2.6.10-rc2-mm4-full/kernel/Makefile.old	2004-12-12 02:45:07.000000000 +0100
> +++ linux-2.6.10-rc2-mm4-full/kernel/Makefile	2004-12-12 02:45:18.000000000 +0100
> @@ -48,7 +48,7 @@
>  	$(call if_changed,gzip)
>  
>  quiet_cmd_ikconfiggz = IKCFG   $@
> -      cmd_ikconfiggz = (echo "const char kernel_config_data[] = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;") > $@
> +      cmd_ikconfiggz = (echo "static const char kernel_config_data[] = MAGIC_START"; cat $< | scripts/bin2c; echo "MAGIC_END;") > $@
>  targets += config_data.h
>  $(obj)/config_data.h: $(obj)/config_data.gz FORCE
>  	$(call if_changed,ikconfiggz)
> 
> -

-- 
~Randy

  reply	other threads:[~2005-01-25 22:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-21 10:07 [2.6 patch] kernel/configs.c: make a variable static Adrian Bunk
2005-01-25 21:56 ` Randy.Dunlap [this message]
2005-01-30 22:25 ` Sam Ravnborg
  -- strict thread matches above, loose matches on Subject: below --
2004-12-12 19:18 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41F6C07A.5010609@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.