All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Dale Farnsworth <dale@farnsworth.org>
Cc: netdev@oss.sgi.com, Ralf Baechle <ralf@linux-mips.org>,
	Manish Lachwani <mlachwani@mvista.com>,
	Brian Waite <brian@waitefamily.us>,
	"Steven J. Hill" <sjhill@realitydiluted.com>
Subject: Re: MV643xx Ethernet 2.6 driver update
Date: Thu, 27 Jan 2005 04:56:26 -0500	[thread overview]
Message-ID: <41F8BACA.1020302@pobox.com> (raw)
In-Reply-To: <20050117184019.GA24655@xyzzy>

Dale Farnsworth wrote:
> While porting the mv643xx ethernet driver to 2.6 and for use on PPC, I
> modified it to use the device driver model, fixed the hardware checksum
> support, and did some miscellaneous bug fixes and cleanups.
> 
> The following changes are included:
> 	
>  A. Remove redundant or unneeded code.
>  B. Replace fixed count spins with udelay/msleep waits on hardware status bits
>  C. Fix code to enable hardware checksum generation for TX packets
>  D. Convert from pci_map_* to dma_map_* interface
>  E. Add device driver model support.
>  F. Add support for several configurable parameters via platform_device
>  G. Make use of MV64340_RX_QUEUE_FILL_ON_TASK macro consistent.
>  H. Simplify mv64340_eth_set_rx_mode()
>  I. Clean up receive buffer sizing
>  J. Call netif_carrier_off/netif_carrier_on on a link down/up condition
>  K. Add support for PHYs/boards that don't support autonegotiation.
> 
> Change E is the only one that modifies the driver interface.
> 
> Change G was sent to me by Steven J Hill <sjhill1@rockwellcollins.com>.
> Change K was sent to me by Brian Waite <brian@waitefamily.us>.
> 
> The first 6 changes were submitted to LKLM on Dec. 13 2004.  Comments
> were received only from Christoph Hellwig <hch@infradead.org> and have
> been addressed.  Changes G-K have been added since then.
> 
> I have some additional (mostly cosmetic, but still significant) cleanups,
> but I'd like to get these in the queue first.
> 
> Thanks,
> Dale Farnsworth
> 
> Please do a
> 
> 	bk pull bk://dfarnsworth.bkbits.net/netdev-2.6-mv643xx-enet


Ouch:

When using BitKeeper, you need to make sure your changes are the only 
ones in the tree.  It doesn't work for me to pull:

mv643xx-enet -> jgarzik-mv643xx-enet -> net-drivers-2.6 -> linus

because that would require pulling the entire netdev-2.6 tree up through 
that chain.

	Jeff

  reply	other threads:[~2005-01-27  9:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-17 18:40 MV643xx Ethernet 2.6 driver update Dale Farnsworth
2005-01-27  9:56 ` Jeff Garzik [this message]
2005-01-27 20:19   ` Dale Farnsworth
2005-01-27 20:31     ` Jeff Garzik
2005-01-27 23:06       ` Benjamin Herrenschmidt
2005-01-27 23:13         ` Manish Lachwani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41F8BACA.1020302@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=brian@waitefamily.us \
    --cc=dale@farnsworth.org \
    --cc=mlachwani@mvista.com \
    --cc=netdev@oss.sgi.com \
    --cc=ralf@linux-mips.org \
    --cc=sjhill@realitydiluted.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.