Re: [NFS][PATCH] Making sure negative lookup entries don't exist

[Steve Dickson <SteveD@redhat.com>]

Mike Waychison wrote:

>>--- linux-2.4.28/fs/nfs/dir.c.orig	2004-08-07 19:26:06.000000000 -0400
>>+++ linux-2.4.28/fs/nfs/dir.c	2005-01-28 13:00:59.402239000 -0500
>>@@ -455,7 +455,11 @@ int nfs_lookup_verify_inode(struct inode
>>  */
>> static inline int nfs_neg_need_reval(struct inode *dir, struct dentry *dentry)
>> {
>>-	if (!nfs_check_verifier(dir, dentry))
>>+	if (IS_ROOT(dentry))
>>+		return 1;
>>    
>>
>
>I don't think this is needed.  Aren't you guaranteed that a root dentry
>will never have ->d_revalidate called?
>  
>
hmm... I guess I didn't realize this...  but it appear your right....

>  
>
>>+	if (__nfs_revalidate_inode(NFS_SERVER(dir), dir))
>>+		return 1;
>>+	if (time_after(NFS_MTIME_UPDATE(dir), dentry->d_time))
>> 		return 1;
>> 	return time_after(jiffies, dentry->d_time + NFS_ATTRTIMEO(dir));
>> }
>>    
>>
>
>Am I missing something? or doesn't nfs_check_verifier do exactly these
>checks already?
>  
>
nfs_check_verifier() calls nfs_revalidate_inode() which checks the 
attribute cache
before doing the getattr, __nfs_revalidate_inode() just does the getattr

steved.



-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs