Re: 2.6.11-rc2-mm2

[Brice Goglin <Brice.Goglin@ens-lyon.fr>]

Andrew Morton a écrit :
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc2/2.6.11-rc2-mm2/
> 
> Changes since 2.6.11-rc2-mm1:
> +fix-kallsyms-insmod-rmmod-race.patch
> +fix-kallsyms-insmod-rmmod-race-fix.patch
> +fix-kallsyms-insmod-rmmod-race-fix-fix.patch
> 
>  fix a modules race

Hi Andrew,

CONFIG_STOP_MACHINE is not defined on my laptop. This breaks module loading.
The reason is that stop_machine_run does nothing, especially
it does not call the function that is passed as a parameter.

Looks like -fix needs another fix :)

What about a patch like this one ?

Regards,
Brice


Signed-off-by: Brice Goglin <Brice.Goglin@ens-lyon.org>

--- linux-mm/include/linux/stop_machine.h.orig	2005-01-29 23:37:11.000000000 +0100
+++ linux-mm/include/linux/stop_machine.h	2005-01-29 23:37:31.000000000 +0100
@@ -57,7 +57,7 @@
  static inline int stop_machine_run(int (*fn)(void *), void *data,
  				   unsigned int cpu)
  {
-	return 0;
+	return fn(data);
  }

  #endif	/* CONFIG_STOP_MACHINE */