From: Tommy Christensen <tommy.christensen@tpack.net>
To: hadi@cyberus.ca
Cc: Jeff Garzik <jgarzik@pobox.com>,
Thomas Spatzier <thomas.spatzier@de.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Hasso Tepper <hasso@estpak.ee>,
Herbert Xu <herbert@gondor.apana.org.au>,
netdev@oss.sgi.com, Paul Jakma <paul@clubi.ie>
Subject: Re: [patch 4/10] s390: network driver.
Date: Mon, 31 Jan 2005 01:31:43 +0100 [thread overview]
Message-ID: <41FD7C6F.3010005@tpack.net> (raw)
In-Reply-To: <1107130177.7847.96.camel@jzny.localdomain>
jamal wrote:
> Tommy,
>
> I wasnt sure why you did:
>
> dev->qdisc = &noop_qdisc;
>
> You should probably save the old qdisc in qdisc_sleeping instead
> and restore it on wakeup - otherwise you always end with default qdisc.
I think normally we will have qdisc == qdisc_sleeping. At least this
is how I read the code in dev_graft_qdisc(). When can they differ?
> check_carrier should probably just call dev_activate which does all you
> wanted, no?
I copied the logic from dev_deactivate(), but I didn't want to include
the waiting parts, since this is not in process context. OK?
-Tommy
next prev parent reply other threads:[~2005-01-31 0:31 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <OF66747F56.DA01CD7C-ON42256F4A.00376891-42256F4A.0037821E@LocalDomain>
2004-11-12 10:28 ` [patch 4/10] s390: network driver Thomas Spatzier
2004-11-14 1:29 ` Jeff Garzik
2004-11-15 7:52 ` Paul Jakma
2004-11-21 8:16 ` Paul Jakma
2004-11-29 15:57 ` Thomas Spatzier
2004-11-29 16:30 ` Paul Jakma
2004-11-29 16:41 ` Thomas Spatzier
2004-11-29 20:27 ` Paul Jakma
2004-11-30 7:22 ` Thomas Spatzier
2004-12-05 6:25 ` Paul Jakma
2004-12-06 11:01 ` Post Network dev questions to netdev Please WAS(Re: " jamal
2004-12-06 11:27 ` jamal
2004-12-06 14:42 ` Hasso Tepper
2004-12-07 1:13 ` Herbert Xu
2004-12-07 2:22 ` jamal
2004-12-10 15:37 ` Paul Jakma
2004-12-14 7:40 ` Thomas Spatzier
2004-12-15 13:50 ` jamal
2004-12-15 15:03 ` Thomas Spatzier
2004-12-19 19:29 ` jamal
2004-12-19 22:29 ` Tommy Christensen
2004-12-19 23:05 ` jamal
2004-12-19 23:46 ` Tommy Christensen
2004-12-20 0:15 ` Jeff Garzik
2004-12-20 14:10 ` jamal
2004-12-20 18:54 ` Jeff Garzik
2004-12-21 0:13 ` Tommy Christensen
2004-12-21 1:19 ` Jeff Garzik
2004-12-22 10:56 ` Thomas Spatzier
2004-12-22 11:07 ` Jeff Garzik
2004-12-22 13:48 ` jamal
2005-01-03 9:10 ` Thomas Spatzier
2005-01-03 15:05 ` jamal
2005-01-04 23:28 ` Jeff Garzik
2005-01-05 3:19 ` jamal
2005-01-05 6:30 ` Paul Jakma
2005-01-05 13:16 ` jamal
2005-01-05 14:29 ` Paul Jakma
2005-01-06 13:55 ` jamal
2005-01-05 15:35 ` Tommy Christensen
2005-01-06 13:58 ` jamal
2005-01-06 15:06 ` Tommy Christensen
2005-01-07 13:32 ` jamal
2005-01-07 15:26 ` Tommy Christensen
2005-01-10 13:18 ` jamal
2005-01-16 23:10 ` jamal
2005-01-17 12:04 ` Hasso Tepper
2005-01-17 22:04 ` Tommy Christensen
2005-01-17 22:13 ` Peter Buckingham
2005-01-17 22:36 ` jamal
2005-01-17 22:53 ` Tommy Christensen
2005-01-17 21:38 ` Tommy Christensen
2005-01-30 23:39 ` Tommy Christensen
2005-01-31 0:09 ` jamal
2005-01-31 0:12 ` jamal
2005-01-31 0:31 ` Tommy Christensen [this message]
2005-01-31 3:26 ` jamal
2005-01-31 12:16 ` Tommy Christensen
2005-03-13 17:49 ` Hasso Tepper
2005-01-05 6:26 ` Paul Jakma
2004-12-20 14:16 ` Paul Jakma
2004-12-20 18:56 ` Jeff Garzik
2004-12-26 5:36 ` Herbert Xu
2004-12-19 22:43 ` Jeff Garzik
2004-12-19 23:54 ` Paul Jakma
2004-12-20 14:11 ` jamal
2004-12-07 2:39 ` jamal
2004-12-06 18:44 ` Paul Jakma
2004-11-11 17:16 Martin Schwidefsky
2004-11-11 22:51 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41FD7C6F.3010005@tpack.net \
--to=tommy.christensen@tpack.net \
--cc=davem@davemloft.net \
--cc=hadi@cyberus.ca \
--cc=hasso@estpak.ee \
--cc=herbert@gondor.apana.org.au \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
--cc=paul@clubi.ie \
--cc=thomas.spatzier@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.