From: Hannes Reinecke <hare@suse.de>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Pavel Machek <pavel@suse.cz>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Resume from initramfs
Date: Mon, 31 Jan 2005 15:26:22 +0100 [thread overview]
Message-ID: <41FE400E.7050604@suse.de> (raw)
In-Reply-To: <1107181117.9518.2.camel@elrond.flymine.org>
Matthew Garrett wrote:
> On Mon, 2005-01-31 at 15:09 +0100, Hannes Reinecke wrote:
>
>
>>swsusp_check is used by both entry points, and is itself not a init
>>function.
>>I simply found it bad style to reference a __init function from there.
>>And name_to_dev_t is evil in itself. I'd gladly be rid of it if possible.
>
>
> name_to_dev_t won't work once userspace has started - you need to
> set_fs(KERNEL_DS) at least one of the calls in it, IIRC.
>
I'm not advocating to use it.
But referencing a non-existing function is just plain evil.
We should better seperate both entry points to do the necessary device
resolution themselves before calling generic functions.
Cheers,
Hannes
--
Dr. Hannes Reinecke hare@suse.de
SuSE Linux AG S390 & zSeries
Maxfeldstraße 5 +49 911 74053 688
90409 Nürnberg http://www.suse.de
next prev parent reply other threads:[~2005-01-31 14:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-31 12:30 [PATCH] Resume from initramfs Hannes Reinecke
2005-01-31 12:43 ` Matthew Garrett
2005-01-31 13:15 ` Hannes Reinecke
2005-01-31 12:51 ` Pavel Machek
2005-01-31 14:09 ` Hannes Reinecke
2005-01-31 14:18 ` Matthew Garrett
2005-01-31 14:26 ` Hannes Reinecke [this message]
2005-01-31 14:26 ` Andreas Schwab
2005-01-31 14:28 ` Hannes Reinecke
2005-01-31 18:15 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41FE400E.7050604@suse.de \
--to=hare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.