From: Timur Tabi <timur.tabi@ammasso.com>
To: Andrew Morton <akpm@osdl.org>
Cc: roland@topspin.com, linux-kernel@vger.kernel.org
Subject: Re: Correct way to release get_user_pages()?
Date: Mon, 31 Jan 2005 09:51:06 -0600 [thread overview]
Message-ID: <41FE53EA.4010101@ammasso.com> (raw)
In-Reply-To: <20050130021017.7ef1c764.akpm@osdl.org>
Andrew Morton wrote:
> no... You should only dirty the page if it was modified, and then use
> set_page_dirty() or set_page_dirty_lock().
If the page was modified, then shouldn't it already be marked dirty?
Also, should I always use set_page_dirty_lock() if I haven't already
locked the page?
--
Timur Tabi
Staff Software Engineer
timur.tabi@ammasso.com
next prev parent reply other threads:[~2005-01-31 15:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-28 3:02 Correct way to release get_user_pages()? Roland Dreier
2005-01-28 17:48 ` Timur Tabi
2005-01-30 10:10 ` Andrew Morton
2005-01-31 15:51 ` Timur Tabi [this message]
2005-01-31 21:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41FE53EA.4010101@ammasso.com \
--to=timur.tabi@ammasso.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@topspin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.