From: Martin Wilck <martin.wilck@fujitsu-siemens.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [Discuss][i386] Platform SMIs and their interferance with tsc based delay calibration
Date: Mon, 31 Jan 2005 18:29:03 +0100 [thread overview]
Message-ID: <41FE6ADF.8030304@fujitsu-siemens.com> (raw)
In-Reply-To: <3s4Tx-1gi-9@gated-at.bofh.it>
Linus Torvalds wrote:
> In particular, I don't see why you didn't just put this in the generic
> calibrate_delay() routine. You seem to have basically duplicated it, and
> added the "guess from an external timer" code - and I don't see what's
> non-generic about that, except for some trivial "what's the current timer"
> lookup.
The trivial lookup is hidden in the __delay() function. Making it return
the number of "loops" it actually waited would help having a robust
generic code.
Regards
Martin
next prev parent reply other threads:[~2005-01-31 17:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3rR0g-3aR-11@gated-at.bofh.it>
2005-01-31 17:25 ` [Discuss][i386] Platform SMIs and their interferance with tsc based delay calibration Martin Wilck
[not found] ` <3s4Tx-1gi-9@gated-at.bofh.it>
2005-01-31 17:29 ` Martin Wilck [this message]
2005-01-29 14:37 Pallipadi, Venkatesh
-- strict thread matches above, loose matches on Subject: below --
2005-01-29 14:36 Pallipadi, Venkatesh
2005-01-29 2:51 Venkatesh Pallipadi
2005-01-29 5:17 ` Andrew Morton
2005-01-29 6:24 ` Andi Kleen
2005-01-29 17:44 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41FE6ADF.8030304@fujitsu-siemens.com \
--to=martin.wilck@fujitsu-siemens.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.