Re: test_root reorder(Re: [patch] ext2: Apply Jack's ext3 speedups)

[Prasanna Meda <pmeda@akamai.com>]

Jan Kara wrote:

> > Prasanna Meda wrote:
> >
> > >   - Folded all three root checkings for 3,  5 and 7 into one loop.
> > >   -  Short cut the loop with 3**n < 5 **n < 7**n logic.
> > >   -  Even numbers can be ruled out.
> >
> > Without going to that complicated path, the better performance
> > is achieved with just reordering  of the tests from 3,5,7 to 7,5.3, so
> > that average case becomes better. This is more simpler than
> >  folding  patch.
>   I like a bit more just to reorder the tests (though I agree that your
> joined tests for 3,5,7 are probably faster) - it looks much more
> readable...

Yes, Also reordering is almost same as folding aproach in
experimental  test. So, there is no need of going to that complicated
 path. Just  reorder 7, 5 and 3 and check for evenness.


Thanks,
Prasanna.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>