Re: [PATCH] ipt_hashlimit.c: expire's type overflow when showing tuples at bad moment.

[Samuel Jean <sj-netfilter@cookinglinux.org>]

Patrick McHardy wrote:
> On my system (x86_64, gcc-3.3.5) va_arg returns 2^32-1 for -1, but it
> should return 2^64-1. Are you seeing this problem on a 32bit or a 64bit
> machine ?

It's on x86 32bits, gcc-3.3.4.
Here's an exemple of consecutive cat:

# cat /proc/net/ipt_hashlimit/moo
0 x.239.59.104:0->0.0.0.0:0 1600 1600 320
0 x.162.158.131:0->0.0.0.0:0 1600 1600 320

# cat /proc/net/ipt_hashlimit/moo
4294967 x.239.59.104:0->0.0.0.0:0 1600 1600 320
4294967 x.162.158.131:0->0.0.0.0:0 1600 1600 320

# cat /proc/net/ipt_hashlimit/moo
#

 From what I can think, it goes bad only when a third operation comes into.
Here's what happen without dividing by HZ.

# cat /proc/net/ipt_hashlimit/moo
6 206.162.158.131:0->0.0.0.0:0 1600 1600 320

# cat /proc/net/ipt_hashlimit/moo
-447 206.162.158.131:0->0.0.0.0:0 1600 1600 320


> 
> Regards
> Patrick
> 
Hope this can help,

Samuel