From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9EBC3AC0CD; Mon, 22 Jun 2026 12:41:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782132088; cv=none; b=C0lmqNfNcShjGxSmOQIeBaI0KC8kpwThrfitNHonSUlHNz55j++UBtqb3VQ3zZTuo8Q+OvQ7c9qeAkLjJF0+HkU2VwGhX4ouum8wlGVKKCKKbsP3cssCocleoXYmKR6uwVZjl/fpyo6EbLxLNH72ZL7KCZDwU+ssvAE9Uu28MDs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782132088; c=relaxed/simple; bh=FZe9L1aOihvNsi1mP/k0gXCo1sbBVdCbhaxSa68d8mY=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=u8H85hzLt6EEqI5t/icdqYbQxn4WRFHATG4Y1pbIFLFJIiQcvi+zVHpbVjfSp++/83iRimczRM2dooj+h1fS6d+pzoUPQhz07HtM+ayNuuTcODM/XZsvUZIQatPTxMy9hxT1M4rkmp8aAjQi7nQqvuoLaMm/JWOHsWXNhi1cjh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=OQxsNm4s; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="OQxsNm4s" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68C7A1F000E9; Mon, 22 Jun 2026 12:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782132086; bh=QGutXJ/UQR7Pm54Zrjalv+sNwgnUcPPhvyee6Rqu+sM=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=OQxsNm4sn4VTg03ihN8zkLau945H9lhQfIBCQGlPgx9vv0cJ8bERM0oiRpjKgsZEc Y+8RguJhc6DGxueH9X6BguAi3rcBeVta1LzamrGBL80SUOoQAGA0QJhMFjaTqVWrdt IMtvzjTFOVEqHtJ/Ww2nfIV1oa2mzXU1t7nN3m3T1Uqdl5sm9u0iAyHs3w0tf54Qlm caMYYfZNbIjsoXHkbdsZk/iI/jfbrfSM2HIk5uq5B+Rrk9F1Pny+QpuhTNXy3JEnk/ 5y+NMCQlfsbJRDlDObp4hkrXlNwIrlndMFyEa4b4I9D9mVs/zDLWcvnpYzFQek1BaJ G5HFkoSOdc3Ww== Message-ID: <41cbc896-016c-411a-bb6e-950e8400ff41@kernel.org> Date: Mon, 22 Jun 2026 20:41:22 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Yunji Kang , Yeongjin Gil , Sungjong Seo Subject: Re: [PATCH v2] f2fs: fix to round down start offset of fallocate for pin file To: Sunmin Jeong , jaegeuk@kernel.org References: <20260622052817.3972188-1-s_min.jeong@samsung.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260622052817.3972188-1-s_min.jeong@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/22/26 13:28, Sunmin Jeong wrote: > Currently, the length of fallocate for pin file is section-aligned to > keep allocated sections from being selected as victims of GC. However, > for the case that the start offset of fallocate is not aligned in > section, the allocated sections can't be fully utilized. It's because a > new section is allocated by f2fs_allocate_pinning_section() after using > blks_per_sec blocks regardless of the start offset. As a result, several > unexpected dirty segments may be created, including blocks assigned to > the pinned file. > > To address this issue, let's round down the start offset of fallocate > to the length of section. > > The reproducing scenario is as below > > chunk=$(((2<<20)+4096)) # 2MB + 4KB > touch test > f2fs_io pinfile set test > f2fs_io fallocate 0 0 $chunk test > f2fs_io fallocate 0 $chunk $chunk test > f2fs_io fallocate 0 $((chunk*2)) $chunk test > f2fs_io fiemap 0 $((chunk*3)) test > > Fiemap: offset = 0 len = 12288 > logical addr. physical addr. length flags > 0 0000000000000000 000000068c600000 0000000000400000 00001088 > 1 0000000000400000 000000003d400000 0000000000001000 00001088 > 2 0000000000401000 00000003eb200000 0000000000200000 00001088 > 3 0000000000601000 00000005e4200000 0000000000001000 00001088 > 4 0000000000602000 0000000605400000 0000000000200000 00001089 > > Cc: stable@vger.kernel.org > Fixes: f5a53edcf01e ("f2fs: support aligned pinned file") > Reviewed-by: Yunji Kang > Reviewed-by: Yeongjin Gil > Reviewed-by: Sungjong Seo > Signed-off-by: Sunmin Jeong Reviewed-by: Chao Yu Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ECECCD98F2 for ; Mon, 22 Jun 2026 12:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:References:To:MIME-Version:Date: Message-ID:Sender:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OUJIIM7kILRGDQ2ixP/AUNa5FYhtPN+tHJDEX7ywNgg=; b=UcxHu3nHUNtLxolfQFc7zBGDJt B1hReJ44QX04aVcLMflpf4lr3sfFBP6YZu0sUdnYunH6VN+7FcnSu1D4otgI1rExO4U4r5p3HPCTI kAlU2ccx1t1SOX09O+TBalQVHfznuI73DVn3VSFc4gqgJKe7lPtfmbBqMdjr/IAYLyNE=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wbdy9-0002dx-Ly; Mon, 22 Jun 2026 12:41:41 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wbdy8-0002dr-DV for linux-f2fs-devel@lists.sourceforge.net; Mon, 22 Jun 2026 12:41:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: From:References:To:Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QGutXJ/UQR7Pm54Zrjalv+sNwgnUcPPhvyee6Rqu+sM=; b=YbcRKOduMLsob8tICw1hGfqqd/ nmSzMC7rOJiJesssNIDjqLTKmi2XWTY1vexTIozQCsdWm+MtIpBDCVgLhcgy9h2Bjsx+Bv2K6n1kL 83na/iFaP57CyGbVEn/EGd9cfhmHJX4OsDjua2pOuyTr8VUFyYA4DE8WNCSmnxBbZU0s=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From:References:To: Subject:Cc:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QGutXJ/UQR7Pm54Zrjalv+sNwgnUcPPhvyee6Rqu+sM=; b=h4H9mZtRNwoFSKHV2/nD7pnBS6 9lf5MjQaeD0G2ExK/EcZaUoA2YnIXQimmgki7ryslnmJKrVc+uJu3yNi4GOAl4RpEFeyri+p8o1pG Z08PsXOU4izL3ZdndXAlSR6dHJtUp7yaJ36XEbzDn9UaeZhkbROZZ/OQkMMdUnjb5KQk=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wbdy4-00067T-FG for linux-f2fs-devel@lists.sourceforge.net; Mon, 22 Jun 2026 12:41:40 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 483EE6008A; Mon, 22 Jun 2026 12:41:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68C7A1F000E9; Mon, 22 Jun 2026 12:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782132086; bh=QGutXJ/UQR7Pm54Zrjalv+sNwgnUcPPhvyee6Rqu+sM=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=OQxsNm4sn4VTg03ihN8zkLau945H9lhQfIBCQGlPgx9vv0cJ8bERM0oiRpjKgsZEc Y+8RguJhc6DGxueH9X6BguAi3rcBeVta1LzamrGBL80SUOoQAGA0QJhMFjaTqVWrdt IMtvzjTFOVEqHtJ/Ww2nfIV1oa2mzXU1t7nN3m3T1Uqdl5sm9u0iAyHs3w0tf54Qlm caMYYfZNbIjsoXHkbdsZk/iI/jfbrfSM2HIk5uq5B+Rrk9F1Pny+QpuhTNXy3JEnk/ 5y+NMCQlfsbJRDlDObp4hkrXlNwIrlndMFyEa4b4I9D9mVs/zDLWcvnpYzFQek1BaJ G5HFkoSOdc3Ww== Message-ID: <41cbc896-016c-411a-bb6e-950e8400ff41@kernel.org> Date: Mon, 22 Jun 2026 20:41:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sunmin Jeong , jaegeuk@kernel.org References: <20260622052817.3972188-1-s_min.jeong@samsung.com> Content-Language: en-US In-Reply-To: <20260622052817.3972188-1-s_min.jeong@samsung.com> X-Headers-End: 1wbdy4-00067T-FG Subject: Re: [f2fs-dev] [PATCH v2] f2fs: fix to round down start offset of fallocate for pin file X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Chao Yu via Linux-f2fs-devel Reply-To: Chao Yu Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Sungjong Seo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 6/22/26 13:28, Sunmin Jeong wrote: > Currently, the length of fallocate for pin file is section-aligned to > keep allocated sections from being selected as victims of GC. However, > for the case that the start offset of fallocate is not aligned in > section, the allocated sections can't be fully utilized. It's because a > new section is allocated by f2fs_allocate_pinning_section() after using > blks_per_sec blocks regardless of the start offset. As a result, several > unexpected dirty segments may be created, including blocks assigned to > the pinned file. > > To address this issue, let's round down the start offset of fallocate > to the length of section. > > The reproducing scenario is as below > > chunk=$(((2<<20)+4096)) # 2MB + 4KB > touch test > f2fs_io pinfile set test > f2fs_io fallocate 0 0 $chunk test > f2fs_io fallocate 0 $chunk $chunk test > f2fs_io fallocate 0 $((chunk*2)) $chunk test > f2fs_io fiemap 0 $((chunk*3)) test > > Fiemap: offset = 0 len = 12288 > logical addr. physical addr. length flags > 0 0000000000000000 000000068c600000 0000000000400000 00001088 > 1 0000000000400000 000000003d400000 0000000000001000 00001088 > 2 0000000000401000 00000003eb200000 0000000000200000 00001088 > 3 0000000000601000 00000005e4200000 0000000000001000 00001088 > 4 0000000000602000 0000000605400000 0000000000200000 00001089 > > Cc: stable@vger.kernel.org > Fixes: f5a53edcf01e ("f2fs: support aligned pinned file") > Reviewed-by: Yunji Kang > Reviewed-by: Yeongjin Gil > Reviewed-by: Sungjong Seo > Signed-off-by: Sunmin Jeong Reviewed-by: Chao Yu Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel