Re: [PATCH v2] arm64: dts: qcom: add initial tree for Samsung Galaxy S22

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/06/2025 22:56, Eric Gonçalves wrote:
> Adds new device support for the Samsung Galaxy S22 (SM-S901E) phone
> 
> Working features:
> - simple-framebuffer
> - side buttons
> - storage
> - usb

Thread and name your patches correctly, e.g. use b4 or git format-patch
-vX -2, and add changelog in cover letter or under '---' of individual
patches describing changes from previous version.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.
</form letter>

> 
> Signed-off-by: Eric Gonçalves <ghatto404@gmail.com>
> ---
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/sm8450-samsung-r0q.dts      | 365 ++++++++++++++++++
>  2 files changed, 366 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> 
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index 669b888b27a1..cde80a17f2ab 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -287,6 +287,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8450-hdk.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8450-qrd.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8450-sony-xperia-nagara-pdx223.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8450-sony-xperia-nagara-pdx224.dtb
> +dtb-$(CONFIG_ARCH_QCOM)	+= sm8450-samsung-r0q.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8550-hdk.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8550-mtp.dtb
>  dtb-$(CONFIG_ARCH_QCOM)	+= sm8550-qrd.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> new file mode 100644
> index 000000000000..cb58626e879e
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> @@ -0,0 +1,365 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (c) 2025, Eric Gonçalves <ghatto404@gmail.com>
> + * Copyright (c) 2025, Arthur Aligon <arthurus36.alt2@tutanota.com>
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +
> +#include "sm8450.dtsi"
> +#include "pm8350.dtsi"
> +#include "pm8350b.dtsi"
> +#include "pm8350c.dtsi"
> +#include "pm8450.dtsi"
> +#include "pmk8350.dtsi"
> +#include "pmr735a.dtsi"
> +
> +/delete-node/ &xbl_ramdump_mem;
> +/delete-node/ &xbl_sc_mem;
> +/delete-node/ &adsp_mem;
> +/delete-node/ &rmtfs_mem;
> +/delete-node/ &mte_mem;
> +/delete-node/ &trusted_apps_mem;
> +/delete-node/ &trusted_apps_ext_mem;
> +
> +/ {
> +	chassis-type = "handset";
> +	model = "Samsung Galaxy S22 (SM-S901E)";
> +	compatible = "samsung,r0q", "qcom,sm8450";
> +
> +	chosen {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +
> +		bootargs = "clk_ignore_unused pd_ignore_unused";

This is not really part of mainline DTS. If it is, then you need to
clearly document the reasons with comment.

> +		linux,initrd-start = <0x00 0xb6915000>;
> +		linux,initrd-end = <0x00 0xb7fff22c>;

Why this has to be in DTS?

Best regards,
Krzysztof