From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A36F2D879E for ; Fri, 26 Jun 2026 02:26:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782440780; cv=none; b=ihfLxJJZFNyUq9Vuy/ObeHRkYG6xEp2pl1xLK7A6BtOsxjuDiGnUrspUNB+K36WeApJ4eYZhcVTQH4vHTw4NwEvp5SiR1v6sYL+Cvmr3QmSnWiN4psQyQB9MU8sGFYV9Nx3erCQWoYr38UpWNOLmcI5Sb+GJrpDxp6LlYfUQMLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782440780; c=relaxed/simple; bh=kT3+Bf8rU1qEUdZdylrBKYZb8hYejQLX+4NG1kVXBsQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VRFYZaY7uXEAS1+Had8Dec20oKnA4pjQ8BYk9BDKQXvHgyKHNkBlW7prD9bBOLHE5yKljI81qSydWcxqE+eK/h8ids0GYhep7B9p5xvomMs5vnm/omE2UzmeakT1vRPJM2/UVP3CECeEe246M8C6hi8vvThkI7bn6Qm69lRlA+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=IJGmabAB; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="IJGmabAB" Message-ID: <41d69217-1263-49bf-906a-8ec84e6ec3b9@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1782440776; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RxVxgroX3On6H8SMBZy+I5j57FDfvO4So/Vpazbn4F4=; b=IJGmabABduP4sFsdxgWiagDoZGsN1Gty6KLeqBQz5lJcnyJTy7PxrtT48EICTwOOeQ1fOB EeIrRiGIw+idFkVTtAqevOW/vztrwyxhh5v4cqGELP1O0ZwG4vRqIYBHfE+X05uaKETI9A eogTHajJcWAaD3WUIo7Dsc31Y3n5fDo= Date: Fri, 26 Jun 2026 10:24:51 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH 2/2] mm: move alloc tag to mm To: Suren Baghdasaryan , akpm@linux-foundation.org Cc: kent.overstreet@linux.dev, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, jackmanb@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20260625184857.2193482-1-surenb@google.com> <20260625184857.2193482-3-surenb@google.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Hao Ge In-Reply-To: <20260625184857.2193482-3-surenb@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 2026/6/26 02:48, Suren Baghdasaryan wrote: > From: Lorenzo Stoakes > > The alloc tagging work is really mm-specific, so move alloc_tag.c to mm/ > and additionally update the MAINTAINERS entry to place it within memory > management and port over the Kconfig and Makefile code to mm. > > Signed-off-by: Lorenzo Stoakes > Signed-off-by: Suren Baghdasaryan I've applied this to my local tree and everything looks good. LGTM. Tested-by: Hao Ge Acked-by: Hao Ge Thanks Best Regards Hao > --- > MAINTAINERS | 20 ++++++++++---------- > lib/Kconfig.debug | 28 ---------------------------- > lib/Makefile | 1 - > mm/Kconfig.debug | 28 ++++++++++++++++++++++++++++ > mm/Makefile | 1 + > {lib => mm}/alloc_tag.c | 0 > 6 files changed, 39 insertions(+), 39 deletions(-) > rename {lib => mm}/alloc_tag.c (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0948dc573744..3cf3cf2311e2 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -16704,16 +16704,6 @@ F: mm/mm_init.c > F: mm/rodata_test.c > F: tools/testing/memblock/ > > -MEMORY ALLOCATION PROFILING > -M: Suren Baghdasaryan > -R: Hao Ge > -L: linux-mm@kvack.org > -S: Maintained > -F: Documentation/mm/allocation-profiling.rst > -F: include/linux/alloc_tag.h > -F: include/linux/pgalloc_tag.h > -F: lib/alloc_tag.c > - > MEMORY CONTROLLER DRIVERS > M: Krzysztof Kozlowski > L: linux-kernel@vger.kernel.org > @@ -16758,6 +16748,16 @@ T: quilt git://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new > F: mm/ > F: tools/mm/ > > +MEMORY MANAGEMENT - ALLOCATION PROFILING (ALLOC TAG) > +M: Suren Baghdasaryan > +R: Hao Ge > +L: linux-mm@kvack.org > +S: Maintained > +F: Documentation/mm/allocation-profiling.rst > +F: include/linux/alloc_tag.h > +F: include/linux/pgalloc_tag.h > +F: mm/alloc_tag.c > + > MEMORY MANAGEMENT - BALLOON > M: Andrew Morton > M: David Hildenbrand > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > index 8ff5adcfe1e0..3762015522c3 100644 > --- a/lib/Kconfig.debug > +++ b/lib/Kconfig.debug > @@ -1048,34 +1048,6 @@ config CODE_TAGGING > bool > select KALLSYMS > > -config MEM_ALLOC_PROFILING > - bool "Enable memory allocation profiling" > - default n > - depends on MMU > - depends on PROC_FS > - depends on !DEBUG_FORCE_WEAK_PER_CPU > - select CODE_TAGGING > - select PAGE_EXTENSION > - select SLAB_OBJ_EXT > - help > - Track allocation source code and record total allocation size > - initiated at that code location. The mechanism can be used to track > - memory leaks with a low performance and memory impact. > - > -config MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT > - bool "Enable memory allocation profiling by default" > - default y > - depends on MEM_ALLOC_PROFILING > - > -config MEM_ALLOC_PROFILING_DEBUG > - bool "Memory allocation profiler debugging" > - default n > - depends on MEM_ALLOC_PROFILING > - select MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT > - help > - Adds warnings with helpful error messages for memory allocation > - profiling. > - > source "lib/Kconfig.kasan" > source "lib/Kconfig.kfence" > source "lib/Kconfig.kmsan" > diff --git a/lib/Makefile b/lib/Makefile > index f33a24bf1c19..44f6538533a9 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -197,7 +197,6 @@ obj-$(CONFIG_OF_RECONFIG_NOTIFIER_ERROR_INJECT) += \ > obj-$(CONFIG_FUNCTION_ERROR_INJECTION) += error-inject.o > > obj-$(CONFIG_CODE_TAGGING) += codetag.o > -obj-$(CONFIG_MEM_ALLOC_PROFILING) += alloc_tag.o > > lib-$(CONFIG_GENERIC_BUG) += bug.o > > diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug > index 91b3e027b753..5737a504efbb 100644 > --- a/mm/Kconfig.debug > +++ b/mm/Kconfig.debug > @@ -320,3 +320,31 @@ config PER_VMA_LOCK_STATS > overhead in the page fault path. > > If in doubt, say N. > + > +config MEM_ALLOC_PROFILING > + bool "Enable memory allocation profiling" > + default n > + depends on MMU > + depends on PROC_FS > + depends on !DEBUG_FORCE_WEAK_PER_CPU > + select CODE_TAGGING > + select PAGE_EXTENSION > + select SLAB_OBJ_EXT > + help > + Track allocation source code and record total allocation size > + initiated at that code location. The mechanism can be used to track > + memory leaks with a low performance and memory impact. > + > +config MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT > + bool "Enable memory allocation profiling by default" > + default y > + depends on MEM_ALLOC_PROFILING > + > +config MEM_ALLOC_PROFILING_DEBUG > + bool "Memory allocation profiler debugging" > + default n > + depends on MEM_ALLOC_PROFILING > + select MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT > + help > + Adds warnings with helpful error messages for memory allocation > + profiling. > diff --git a/mm/Makefile b/mm/Makefile > index eff9f9e7e061..4fc713867b9b 100644 > --- a/mm/Makefile > +++ b/mm/Makefile > @@ -147,3 +147,4 @@ obj-$(CONFIG_SHRINKER_DEBUG) += shrinker_debug.o > obj-$(CONFIG_EXECMEM) += execmem.o > obj-$(CONFIG_TMPFS_QUOTA) += shmem_quota.o > obj-$(CONFIG_LAZY_MMU_MODE_KUNIT_TEST) += tests/lazy_mmu_mode_kunit.o > +obj-$(CONFIG_MEM_ALLOC_PROFILING) += alloc_tag.o > diff --git a/lib/alloc_tag.c b/mm/alloc_tag.c > similarity index 100% > rename from lib/alloc_tag.c > rename to mm/alloc_tag.c