All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: Alex Henrie <alexhenrie24@gmail.com>,
	netdev@vger.kernel.org, kernel@vger.kernel.org,
	regressions@lists.linux.dev, dan@danm.net, bagasdotme@gmail.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	linux-pabeni@redhat.com, jikos@kernel.org
Subject: Re: [PATCH] Revert "net: ipv6/addrconf: clamp preferred_lft to the minimum required"
Date: Sat, 30 Dec 2023 08:43:23 -0700	[thread overview]
Message-ID: <41f047b1-e871-404f-9afe-e4d5f9012c01@kernel.org> (raw)
In-Reply-To: <20231230043252.10530-1-alexhenrie24@gmail.com>

On 12/29/23 11:32 PM, Alex Henrie wrote:
> The commit had a bug and might not have been the right approach anyway.
> 
> Fixes: 629df6701c8a ("net: ipv6/addrconf: clamp preferred_lft to the minimum required")
> Fixes: ec575f885e3e ("Documentation: networking: explain what happens if temp_prefered_lft is too small or too large")
> Reported-by: Dan Moulding <dan@danm.net>
> Closes: https://lore.kernel.org/netdev/20231221231115.12402-1-dan@danm.net/
> Link: https://lore.kernel.org/netdev/CAMMLpeTdYhd=7hhPi2Y7pwdPCgnnW5JYh-bu3hSc7im39uxnEA@mail.gmail.com/
> Signed-off-by: Alex Henrie <alexhenrie24@gmail.com>
> ---
>  Documentation/networking/ip-sysctl.rst |  2 +-
>  net/ipv6/addrconf.c                    | 18 +++++-------------
>  2 files changed, 6 insertions(+), 14 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>



  reply	other threads:[~2023-12-30 15:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21 23:10 [REGRESSION] net/ipv6/addrconf: Temporary addresses with short lifetimes generating when they shouldn't, causing applications to fail Dan Moulding
2023-12-22 13:22 ` Bagas Sanjaya
2023-12-22 15:37   ` Dan Moulding
2023-12-22 23:42 ` Alex Henrie
2023-12-22 23:42   ` [PATCH net] net: ipv6/addrconf: clamp temporary address's preferred lifetime to public address's Alex Henrie
2023-12-23 15:22   ` [REGRESSION] net/ipv6/addrconf: Temporary addresses with short lifetimes generating when they shouldn't, causing applications to fail Dan Moulding
2023-12-24  0:07     ` Alex Henrie
2023-12-29 16:33       ` Dan Moulding
2023-12-29 22:52         ` David Ahern
2023-12-30  4:32           ` [PATCH] Revert "net: ipv6/addrconf: clamp preferred_lft to the minimum required" Alex Henrie
2023-12-30 15:43             ` David Ahern [this message]
2024-01-02 23:10             ` patchwork-bot+netdevbpf
2023-12-30  4:12         ` [REGRESSION] net/ipv6/addrconf: Temporary addresses with short lifetimes generating when they shouldn't, causing applications to fail Alex Henrie
2023-12-23  8:42 ` Linux regression tracking #adding (Thorsten Leemhuis)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41f047b1-e871-404f-9afe-e4d5f9012c01@kernel.org \
    --to=dsahern@kernel.org \
    --cc=alexhenrie24@gmail.com \
    --cc=bagasdotme@gmail.com \
    --cc=dan@danm.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jikos@kernel.org \
    --cc=kernel@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-pabeni@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.