From: David Ahern <dsahern@kernel.org>
To: Wojciech Drewek <wojciech.drewek@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH iproute2-next v2 2/2] f_flower: implement pfcp opts
Date: Sat, 20 Apr 2024 19:53:39 -0600 [thread overview]
Message-ID: <41fc42a1-a0ed-4bbc-9bf5-d5876431497d@kernel.org> (raw)
In-Reply-To: <7d57d275-b58b-4b88-9436-863b5770cee8@intel.com>
On 4/16/24 4:20 AM, Wojciech Drewek wrote:
>
>
> On 15.04.2024 23:52, Stephen Hemminger wrote:
>> On Mon, 15 Apr 2024 14:50:00 +0200
>> Wojciech Drewek <wojciech.drewek@intel.com> wrote:
>>
>>> } else if (key_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP]) {
>>> + flower_print_pfcp_opts("pfcp_opt_key",
>>> + key_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP],
>>> + key, len);
>>> +
>>> + if (msk_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP])
>>> + flower_print_pfcp_opts("pfcp_opt_mask",
>>> + msk_tb[TCA_FLOWER_KEY_ENC_OPTS_PFCP],
>>> + msk, len);
>>> +
>>> + flower_print_enc_parts(name, " pfcp_opts %s", attr, key,
>>> + msk);
>>> }
>>
>> I find the output with pfcp_opt_key and pfcp_opt_mask encoded as hex,
>> awkward when JSON.
>
> But we don't support JSON output for pfcp_opts.
> Do you want me to implement it?
>
json support is preferred.
prev parent reply other threads:[~2024-04-21 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 12:49 [PATCH iproute2-next v2 0/2] PFCP support Wojciech Drewek
2024-04-15 12:49 ` [PATCH iproute2-next v2 1/2] ip: PFCP device support Wojciech Drewek
2024-04-15 12:50 ` [PATCH iproute2-next v2 2/2] f_flower: implement pfcp opts Wojciech Drewek
2024-04-15 21:52 ` Stephen Hemminger
2024-04-16 10:20 ` Wojciech Drewek
2024-04-21 1:53 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41fc42a1-a0ed-4bbc-9bf5-d5876431497d@kernel.org \
--to=dsahern@kernel.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.