From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
npiggin@gmail.com, benh@kernel.crashing.org, paulus@samba.org
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: powerpc/mm/hash: Remove unnecessary do { }while(0) loop
Date: Mon, 13 Aug 2018 21:23:18 +1000 (AEST) [thread overview]
Message-ID: <41ptdL6hVDz9sCW@ozlabs.org> (raw)
In-Reply-To: <20180809133642.16007-1-aneesh.kumar@linux.ibm.com>
On Thu, 2018-08-09 at 13:36:42 UTC, "Aneesh Kumar K.V" wrote:
> Avoid coverity false warnings like
>
> *** CID 187347: Control flow issues (UNREACHABLE)
> /arch/powerpc/mm/hash_native_64.c: 819 in native_flush_hash_range()
> 813 slot += hidx & _PTEIDX_GROUP_IX;
> 814 hptep = htab_address + slot;
> 815 want_v = hpte_encode_avpn(vpn, psize, ssize);
> 816 hpte_v = hpte_get_old_v(hptep);
> 817
> 818 if (!HPTE_V_COMPARE(hpte_v, want_v) || !(hpte_v & HPTE_V_VALID))
> >>> CID 187347: Control flow issues (UNREACHABLE)
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/f405b510c93eeb7390d0e2c6ef8d12
cheers
prev parent reply other threads:[~2018-08-13 11:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-09 13:36 [PATCH] powerpc/mm/hash: Remove unnecessary do { }while(0) loop Aneesh Kumar K.V
2018-08-13 11:23 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41ptdL6hVDz9sCW@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=aneesh.kumar@linux.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.