All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brett Russ <russb@emc.com>
To: linux-ide@vger.kernel.org
Subject: [PATCH] libata-dev-2.6: verify cmd bug fixes/support
Date: Tue, 01 Feb 2005 19:34:43 -0500	[thread overview]
Message-ID: <42002023.9060606@emc.com> (raw)

Below find a patch which gets the read verify command working.  Note 
that in order to get this 100% working one also needs to apply Albert 
Lee's patch:
http://article.gmane.org/gmane.linux.ide/2798
to libata* before or after this.  I've stripped out his portion of the 
changes because I can't sign off on his work.

This work was verified using a SATA bus analyzer and the sg_verify 
utility which sends VERIFY_10.  Should libata support VERIFY_12?

Signed-off-by: Brett Russ <russb@emc.com>

===== drivers/scsi/libata-scsi.c 1.68 vs edited =====
--- 1.68/drivers/scsi/libata-scsi.c     2004-12-29 02:35:53 -05:00
+++ edited/drivers/scsi/libata-scsi.c   2005-02-01 19:26:55 -05:00
@@ -741,13 +741,18 @@
         }

         if (lba48) {
+               tf->command = ATA_CMD_VERIFY_EXT;
+
                 tf->hob_nsect = (n_sect >> 8) & 0xff;

                 tf->hob_lbah = (sect >> 40) & 0xff;
                 tf->hob_lbam = (sect >> 32) & 0xff;
                 tf->hob_lbal = (sect >> 24) & 0xff;
-       } else
+       } else {
+               tf->command = ATA_CMD_VERIFY;
+
                 tf->device |= (sect >> 24) & 0xf;
+       }

         tf->nsect = n_sect & 0xff;

===== include/linux/ata.h 1.20 vs edited =====
--- 1.20/include/linux/ata.h    2004-11-14 03:21:22 -05:00
+++ edited/include/linux/ata.h  2005-02-01 16:28:09 -05:00
@@ -123,6 +123,9 @@
         ATA_CMD_PIO_WRITE_EXT   = 0x34,
         ATA_CMD_SET_FEATURES    = 0xEF,
         ATA_CMD_PACKET          = 0xA0,
+       ATA_CMD_VERIFY          = 0x40,
+       ATA_CMD_VERIFY_EXT      = 0x42,
+

         /* SETFEATURES stuff */
         SETFEATURES_XFER        = 0x03,

             reply	other threads:[~2005-02-02  0:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-02  0:34 Brett Russ [this message]
2005-02-02  3:33 ` [PATCH] libata-dev-2.6: verify cmd bug fixes/support Jeff Garzik
2005-02-02 13:19   ` [PATCH] libata-2.6: " Brett Russ
2005-02-06  1:31     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42002023.9060606@emc.com \
    --to=russb@emc.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.