From: Matthew Dobson <colpatch@us.ibm.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] i386/mach-default/topology.c: make cpu_devices static
Date: Wed, 02 Feb 2005 15:14:32 -0800 [thread overview]
Message-ID: <42015ED8.9000303@us.ibm.com> (raw)
In-Reply-To: <20050131234228.GS21437@stusta.de>
Looks good to me!
Acked-by: Matthew Dobson <colpatch@us.ibm.com>
Adrian Bunk wrote:
>This patch makes a needlessly global struct static.
>
>Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
>---
>
> arch/i386/mach-default/topology.c | 2 +-
> include/asm-i386/cpu.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
>This patch was already sent on:
>- 16 Jan 2005
>
>--- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old 2005-01-16 05:41:55.000000000 +0100
>+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h 2005-01-16 05:42:09.000000000 +0100
>@@ -12,7 +12,6 @@
> struct i386_cpu {
> struct cpu cpu;
> };
>-extern struct i386_cpu cpu_devices[NR_CPUS];
> extern int arch_register_cpu(int num);
> #ifdef CONFIG_HOTPLUG_CPU
> extern void arch_unregister_cpu(int);
>--- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.000000000 +0100
>+++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.000000000 +0100
>@@ -30,7 +30,7 @@
> #include <linux/nodemask.h>
> #include <asm/cpu.h>
>
>-struct i386_cpu cpu_devices[NR_CPUS];
>+static struct i386_cpu cpu_devices[NR_CPUS];
>
> int arch_register_cpu(int num){
> struct node *parent = NULL;
>
>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>
next prev parent reply other threads:[~2005-02-02 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-31 23:42 [2.6 patch] i386/mach-default/topology.c: make cpu_devices static Adrian Bunk
2005-02-02 23:14 ` Matthew Dobson [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-01-16 7:57 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42015ED8.9000303@us.ibm.com \
--to=colpatch@us.ibm.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.