From: David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
To: xen-devel@lists.sourceforge.net
Subject: Re: [PATCH] Trivial fix for latent bug in page_alloc.c
Date: Wed, 02 Feb 2005 23:31:12 +0000 [thread overview]
Message-ID: <420162C0.9000404@blueyonder.co.uk> (raw)
In-Reply-To: <1107317570.10400.38.camel@localhost.localdomain>
Rusty Russell wrote:
>>>@@ -251,17 +249,18 @@
>>> int i;
>>> struct pfn_info *pg;
>>>
>>>- if ( unlikely(order < MIN_ORDER) || unlikely(order > MAX_ORDER) )
>>>+ ASSERT(order >= 0);
>>>+ if ( unlikely(order >= MAX_ORDER) )
>>> return NULL;
>>
[...]
>>Also changing > to >= is wrong.
>
> Well, it's consistent with the rest of the patch.
How so? 'order == MAX_ORDER' is possible and valid, unless MAX_ORDER is
misnamed.
--
David Hopwood <david.nospam.hopwood@blueyonder.co.uk>
-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
next prev parent reply other threads:[~2005-02-02 23:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-19 3:53 [PATCH] Trivial fix for latent bug in page_alloc.c Rusty Russell
2005-01-19 7:51 ` Keir Fraser
2005-01-19 16:45 ` David Hopwood
2005-02-02 4:12 ` Rusty Russell
2005-02-02 23:31 ` David Hopwood [this message]
2005-02-08 2:32 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420162C0.9000404@blueyonder.co.uk \
--to=david.nospam.hopwood@blueyonder.co.uk \
--cc=xen-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.