From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v5 10/10] qede: Enable PMD build
Date: Mon, 18 Apr 2016 17:37:38 +0200
Message-ID: <4202835.rtEgrshY1X@xps13>
References: <1459476927-21387-1-git-send-email-rasesh.mody@qlogic.com>
 <1459476927-21387-11-git-send-email-rasesh.mody@qlogic.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: bruce.richardson@intel.com, dev@dpdk.org, stephen@networkplumber.org,
 ameen.rahman@qlogic.com, harish.patil@qlogic.com, sony.chacko@qlogic.com
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 1E2532C6A
 for <dev@dpdk.org>; Mon, 18 Apr 2016 17:37:40 +0200 (CEST)
Received: by mail-wm0-f44.google.com with SMTP id v188so125370591wme.1
 for <dev@dpdk.org>; Mon, 18 Apr 2016 08:37:40 -0700 (PDT)
In-Reply-To: <1459476927-21387-11-git-send-email-rasesh.mody@qlogic.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-31 19:15, Rasesh Mody:
> --- a/config/common_base
> +++ b/config/common_base
> +CONFIG_RTE_LIBRTE_QEDE_RX_COAL_US=24
> +CONFIG_RTE_LIBRTE_QEDE_TX_COAL_US=48

It looks to be some tuning which could be done at runtime. Isn't it?

> +CONFIG_RTE_LIBRTE_QEDE_TX_SWITCHING=y

Is it possible to enable this feature at runtime?

> +#Provides path/name of the firmware file
> +CONFIG_RTE_LIBRTE_QEDE_FW=n

Should we replace n by a string?
Why not defaults to an empty string?