From: Jan Beulich <jbeulich@suse.com>
To: dmkhn@proton.me
Cc: andrew.cooper3@citrix.com, anthony.perard@vates.tech,
julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com,
sstabellini@kernel.org, dmukhin@ford.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/console: make console buffer size configurable
Date: Tue, 18 Feb 2025 17:05:27 +0100 [thread overview]
Message-ID: <4203576f-0b93-4647-9983-e36c15fa1d0c@suse.com> (raw)
In-Reply-To: <20250212222157.2974150-1-dmukhin@ford.com>
On 12.02.2025 23:31, dmkhn@proton.me wrote:
> --- a/xen/drivers/char/Kconfig
> +++ b/xen/drivers/char/Kconfig
> @@ -96,6 +96,18 @@ config SERIAL_TX_BUFSIZE
>
> Default value is 32768 (32KiB).
>
> +config CONRING_SIZE
> + int "Console buffer size"
> + default 32768
> + range 16384 134217728
> + help
> + Select the boot console buffer size (in bytes).
Why in bytes when ...
> + Note, the value provided will be rounded down to the nearest power of 2.
... this rounding is done anyway? Why have people type in complicated numbers?
A granularity of 1k would already be an improvement; yet better would be if
this was a power-of-two value altogether.
Jan
next prev parent reply other threads:[~2025-02-18 16:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 22:31 [PATCH] xen/console: make console buffer size configurable dmkhn
2025-02-13 23:04 ` Stefano Stabellini
2025-02-18 16:05 ` Jan Beulich [this message]
2025-02-21 20:52 ` Denis Mukhin
2025-02-21 22:13 ` Marek Marczykowski-Górecki
2025-03-05 1:14 ` Denis Mukhin
2025-02-24 10:44 ` Jan Beulich
2025-02-25 2:45 ` Denis Mukhin
2025-02-25 7:23 ` Jan Beulich
2025-03-05 1:16 ` Denis Mukhin
2025-03-05 1:14 ` Denis Mukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4203576f-0b93-4647-9983-e36c15fa1d0c@suse.com \
--to=jbeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@vates.tech \
--cc=dmkhn@proton.me \
--cc=dmukhin@ford.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.