All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Subject: Re: [PATCH] ethdev: report error on name truncation
Date: Mon, 07 Jan 2019 15:50:16 +0100	[thread overview]
Message-ID: <4204389.yEGWC8VWic@xps> (raw)
In-Reply-To: <20190107143951.30076-1-ndabilpuram@marvell.com>

Hi,

Please provide an explanation of the current behaviour.

07/01/2019 15:40, Nithin Kumar Dabilpuram:
> -	snprintf(z_name, sizeof(z_name), "eth_p%d_q%d_%s",
> -		 dev->data->port_id, queue_id, ring_name);
> +	rc = snprintf(z_name, sizeof(z_name), "%s_%s_%d_%d",
> +		      dev->device->driver->name, ring_name,
> +		      dev->data->port_id, queue_id);

You should keep the same name format.
Please check this commit:
	http://git.dpdk.org/dpdk/commit/?id=5e046832

  parent reply	other threads:[~2019-01-07 14:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 14:40 [PATCH] ethdev: report error on name truncation Nithin Kumar Dabilpuram
2019-01-07 14:47 ` Andrew Rybchenko
2019-01-07 15:53   ` Stephen Hemminger
2019-01-07 16:17     ` Andrew Rybchenko
2019-01-08  6:06   ` [EXT] " Nithin Kumar Dabilpuram
2019-01-07 14:50 ` Thomas Monjalon [this message]
2019-01-08  5:32   ` Nithin Kumar Dabilpuram
2019-01-13 15:38 ` [PATCH v2] " Nithin Kumar Dabilpuram
2019-01-13 19:28   ` Wiles, Keith
2019-01-13 20:02     ` Thomas Monjalon
2019-01-13 20:19       ` Wiles, Keith
2019-01-13 21:21         ` Thomas Monjalon
2019-01-14  7:32           ` Andrew Rybchenko
2019-01-14 14:30   ` Thomas Monjalon
2019-01-17 14:13 ` [PATCH v3] " Nithin Kumar Dabilpuram
2019-01-17 15:38   ` Thomas Monjalon
2019-01-17 17:07     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4204389.yEGWC8VWic@xps \
    --to=thomas@monjalon.net \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=ndabilpuram@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.