From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFA16606A32E for ; Sat, 7 Nov 2026 14:55:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=H/jFH1TP; dkim=fail reason="signature verification failed" (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=Vx4J4G9N DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=P4vdRPx1+mCGSug6b/nW/YKQRd5YpD+Tnfn/Y/7AEXw=; b=H/jFH1TPKmS2sWp55gqpqJ0EJw jpGPnZSORPYZxzu7n9rnGYbeSreA00RzN1oaoFekYswvLvMIg0T7Lik6lGRo4G6YmCl5iwClPS4rz RKeWBva4YoqUtyet798JY8pq1QW6IrtZdnwsSpmvYdX4skgn1vce4Ci8W023D8d8Io5oNiawm6LNK RFfVgVmrBenUO+6SHGdhIRFi5q9di08MLWkCTzQvdmAVKprYownj1tGbPdRvK6v/X6t5SDJ1X9Xu/ 5KEkiuQMwGh6L0vtrmK2pVChXJJprCXzpq4uMfjJnkJM3mRQoKEubZa3WRdXRjW1ItZjeV0I2WZuB 5h0gSlJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPhpD-0000000EroG-05vC; Sat, 07 Nov 2026 14:55:23 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPhpA-0000000ErmP-3BW1; Sat, 07 Nov 2026 14:55:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=9fZSnTYT8MA9EbRBaUvLqKYLQu5iORlXOvx+G3Uf2Jc=; b=Vx4J4G9No9bGRJ4Vs0GPjrqjeT ToMpI2Vl+Ww2kkw+zMNU1/iDDpUDu3YRotlBkpj9gKNB74bBHTypCnSy/xC6d1DK5LDIQooU3Vn91 o6AcmQvggAkz/uvzI1jyu03Km0tXEYX8qPdITP2+kuMINdoUeyob16qSdX45z4wObi5ieN66BW4ue BlgYsfBOIb2JOxJ6hUKlbwpjiJbWc7qZq7ZNfsQWKZFAPa6g2PANLncMplYImLQAgsqbMNE5yxtfy EccGTLdNgh9J4QLQXaN9VRoPbwqYorjGX0D+jkVxeA1ntzsyI4FcN8YGopY6zSra3Nd5Q2S7OUulz BvedVQwA==; From: Heiko Stuebner To: rafael@kernel.org, Daniel Lezcano Cc: Daniel Lezcano , Shuah Khan , Manaf Meethalavalappu Pallikunhi , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 4/6] powercap: dtpm: Use generic powercap hierarchy helpers Date: Sat, 07 Nov 2026 15:55:14 +0100 Message-ID: <4204877.2iPT33SAM4@phil> In-Reply-To: References: X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261107_065520_801112_4112397A X-CRM114-Status: GOOD ( 18.62 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 QW0gRGllbnN0YWcsIDMuIE5vdmVtYmVyIDIwMjYsIDA1OjQ4OjE4IE1pdHRlbGV1cm9ww6Rpc2No ZSBOb3JtYWx6ZWl0IHNjaHJpZWIgRGFuaWVsIExlemNhbm86Cj4gRFRQTSBpbXBsZW1lbnRzIGl0 cyBvd24gaGllcmFyY2h5IGNyZWF0aW9uIGFuZCBkZXN0cnVjdGlvbiBsb2dpYyB3aGlsZQo+IHRo ZSBwb3dlcmNhcCBjb3JlIG5vdyBwcm92aWRlcyBnZW5lcmljIGhlbHBlcnMgZm9yIHRoaXMgcHVy cG9zZS4KPiAKPiBDb252ZXJ0IERUUE0gdG8gdXNlIHRoZSBnZW5lcmljIHBvd2VyY2FwIGhpZXJh cmNoeSBpbmZyYXN0cnVjdHVyZS4KPiBEdXBsaWNhdGUgdGhlIHBsYXRmb3JtIGhpZXJhcmNoeSBi ZWZvcmUgY3JlYXRpbmcgaXQsIGFuZCB1c2UKPiBwb3dlcmNhcF9oaWVyYXJjaHlfY3JlYXRlKCkg YW5kIHBvd2VyY2FwX2hpZXJhcmNoeV9kZXN0cm95KCkgdG8gbWFuYWdlCj4gdGhlIERUUE0gem9u ZXMuCj4gCj4gQWRkIERUUE0gY2FsbGJhY2tzIHRvIGNyZWF0ZSBhbmQgZGVzdHJveSB0aGUgem9u ZXMgYXNzb2NpYXRlZCB3aXRoIGVhY2gKPiBwb3dlcmNhcCBoaWVyYXJjaHkgbm9kZS4gQWRhcHQg dGhlIENQVSBhbmQgZGV2ZnJlcSBiYWNrZW5kcyB0byByZXR1cm4KPiB0aGUgY3JlYXRlZCBEVFBN IGluc3RhbmNlIGFuZCB1c2UgdGhlIG5vZGUgbmFtZSBwcm92aWRlZCBieSB0aGUKPiBoaWVyYXJj aHkuCj4gCj4gQ29udmVydCB0aGUgUm9ja2NoaXAgUkszMzk5IGRlc2NyaXB0aW9uIHRvIHN0cnVj dCBwb3dlcmNhcF9oaWVyYXJjaHkKPiBhbmQga2VlcCB0aGUgZGV2aWNlIHRyZWUgcGF0aCBhcyBE VFBNLXNwZWNpZmljIG5vZGUgZGF0YS4KPiAKPiBUaGlzIHJlbW92ZXMgdGhlIERUUE0tc3BlY2lm aWMgaGllcmFyY2h5IHRyYXZlcnNhbCBhbmQgZGVzdHJ1Y3Rpb24gY29kZQo+IGFuZCBsZWF2ZXMg dGhlIGhpZXJhcmNoeSBtYW5hZ2VtZW50IHRvIHRoZSBwb3dlcmNhcCBjb3JlLgo+IAo+IFByZXNl cnZlIGJlc3QtZWZmb3J0IGNyZWF0aW9uOiBhbiB1bmF2YWlsYWJsZSBiYWNrZW5kIHJldHVybnMg TlVMTCB0bwo+IHNraXAgaXRzIGJyYW5jaCwgYW5kIHNldHVwIGZhaWx1cmVzIGFyZSB3YXJuZWQg YWJvdXQgYW5kIHNraXBwZWQgcmF0aGVyCj4gdGhhbiByb2xsaW5nIGJhY2sgaW5kZXBlbmRlbnQg em9uZXMuIEludmFsaWQgbm9kZSBkZXNjcmlwdG9ycyByZW1haW4KPiBmYXRhbC4gUmVqZWN0IGEg RFQgbm9kZSB3aXRoIGEgTlVMTCBwYXRoIGJlZm9yZSBjYWxsaW5nCj4gb2ZfZmluZF9ub2RlX2J5 X3BhdGgoKSwgdHJlYXRpbmcgaXQgYXMgYW4gaW52YWxpZCBkZXNjcmlwdG9yIHJhdGhlcgo+IHRo YW4gYW4gdW5hdmFpbGFibGUgYmFja2VuZC4KPiAKPiBXaGVuIHRoZSByZXByZXNlbnRhdGl2ZSBD UFUgaXMgb2ZmbGluZSwgZmluZCBhbiBhY3RpdmUgcG9saWN5IHRocm91Z2ggYW4KPiBvbmxpbmUg c2libGluZyB3aG9zZSByZWxhdGVkX2NwdXMgbWFzayBjb250YWlucyBpdC4gSG9sZCB0aGUgQ1BV IGhvdHBsdWcKPiByZWFkIGxvY2sgZHVyaW5nIHNlbGVjdGlvbiBhbmQgc2V0dXAsIGFuZCBpbml0 aWFsaXplIHRoZSB6b25lIHRocm91Z2ggdGhlCj4gcG9saWN5J3MgYWN0aXZlIENQVSB3aGlsZSBr ZWVwaW5nIHRoZSBoaWVyYXJjaHktcHJvdmlkZWQgbmFtZS4gQW4gZW50aXJlbHkKPiBvZmZsaW5l IHBvbGljeSBzdGlsbCBoYXMgbm8gYWN0aXZlIENQVSB0byBpbml0aWFsaXplIHRocm91Z2guCj4g Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIExlemNhbm8gPGRhbmllbC5sZXpjYW5vQG9zcy5xdWFs Y29tbS5jb20+Cj4gLS0tCj4gQ2hhbmdlcyBpbiB2NSAoc2luY2UgdjQpOgo+IC0gUmVqZWN0IGEg TlVMTCBEVCBub2RlIHBhdGggd2l0aCAtRUlOVkFMIGJlZm9yZSBpbnZva2luZwo+ICAgZHRwbV9z ZXR1cF9kdCgpLCBhcyBzdWdnZXN0ZWQgYnkgTHVrYXN6IEx1YmEuCj4gLSBEb2N1bWVudCB0aGF0 IGEgbWlzc2luZyBwYXRoIGlzIGFuIGludmFsaWQgaGllcmFyY2h5IGRlc2NyaXB0b3IuCj4gCj4g Q2hhbmdlcyBpbiB2NCAoc2luY2UgdjMpOgo+IC0gUmViYXNlIG9uIHY3LjM7IG5vIGNvZGUgb3Ig Y29tbWl0LWRlc2NyaXB0aW9uIGNoYW5nZXMuCj4gCj4gQ2hhbmdlcyBpbiB2MyAoc2luY2UgdjIp Ogo+IC0gUmViYXNlIG9uIHY3LjMtcmM3Lgo+IC0gUHJlc2VydmUgYmVzdC1lZmZvcnQgYnJhbmNo IGNyZWF0aW9uIHVzaW5nIHRoZSBnZW5lcmljIE5VTEwgcmVzdWx0Lgo+IC0gRmluZCBhbiBvbmxp bmUgcG9saWN5IHNpYmxpbmcgZm9yIG9mZmxpbmUgQ1BVIHJlcHJlc2VudGF0aXZlcyBhbmQKPiAg IHByb3RlY3QgcG9saWN5IHNlbGVjdGlvbiBhbmQgc2V0dXAgYWdhaW5zdCBDUFUgaG90cGx1Zy4K PiAtIEtlZXAgZ2VuZXJpYyBBUEkgYmVoYXZpb3IgYW5kIGRvY3VtZW50YXRpb24gaW4gcGF0Y2gg MS4KPiAtIEZpeCBfX2luaXRkYXRhIHBsYWNlbWVudDsgbWF0Y2gtdGFibGUgaW5kZW50YXRpb24g aXMgaGFuZGxlZCBpbiBwYXRjaCAzLgo+IC0gTmFtZSBzZXR1cCBjYWxsYmFjayBhcmd1bWVudHMg YW5kIHJlbW92ZSB3aGl0ZXNwYWNlLW9ubHkgbGluZXMuCj4gLSBVcGRhdGUgdGhlIGRlc2NyaXB0 aW9uLgo+IAo+ICBkcml2ZXJzL3Bvd2VyY2FwL2R0cG0uYyAgICAgICAgIHwgMTgwICsrKysrKysr KysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvcG93ZXJjYXAvZHRwbV9jcHUuYyAg ICAgfCAgNjIgKysrKysrKystLS0KPiAgZHJpdmVycy9wb3dlcmNhcC9kdHBtX2RldmZyZXEuYyB8 ICAyMiArKy0tCj4gIGRyaXZlcnMvc29jL3JvY2tjaGlwL2R0cG0uYyAgICAgfCAgNjcgKysrKysr KysrLS0tCj4gIGluY2x1ZGUvbGludXgvZHRwbS5oICAgICAgICAgICAgfCAgIDYgKy0KPiAgNSBm aWxlcyBjaGFuZ2VkLCAxOTggaW5zZXJ0aW9ucygrKSwgMTM5IGRlbGV0aW9ucygtKQoKSSB0cmll ZCB0byBmb2xsb3cgYWxvbmcgYW5kIHRoZSBjaGFuZ2VzIGxvb2sgb2ssIGJ1dCBJIGRvbid0IGtu b3cgdGhlCm1vcmUgaW50cmljYXRlIGRldGFpbHMsIHNvCgpBY2tlZC1ieTogSGVpa28gU3R1ZWJu ZXIgPGhlaWtvQHNudGVjaC5kZT4KCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlw QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1yb2NrY2hpcAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794063322; b=pJ5CouKoX9x3z+JQGhgCxha6Rtnv/KjvKTOQmhKGi01VQisqQNG3M2esLeN5OqplEVkV ppkf6xIPWefIFWVpxNz4pZpIU3c7EKY0hkHkuRMob/ijoDzsXD9QGcyUoz9nxO3DIaZWR UdAtEjL4f+YbAUAv3Xd74562ebjrI2u697nZ4SNDmDF/gky8Jd0G9xYZCmKt0bY8MhpCb +UkJebGb+Gm4gns9uTS7X5VDrI1a/Jces6bwKOJ3gO3eqvgGaJXu7UHdREyZx2aGEB9P7 juITjXPA/ZBI2cawLVIJfLCDRpIkKIjiOhNFBYTk1LqQ3cyUz3Ny30DO3n+IW0wvgVA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794063322; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=9fZSnTYT8MA9EbRBaUvLqKYLQu5iORlXOvx+G3Uf2Jc=; b=LW9exvLR/ep8ccOpKo60rB9A5fSjwLQnXFAOOwGeLwViUYNNDwqB8INBRxGGR75Kq2DT z1238mP91j4xYPvaijw77hShk3ce7SnB13wzT+3mcqtehZi2MZsqK+4igIMTRPFjzWIOu 3VKbKfh9/jKVmtHHFpDH3SbIsVUMIIerSkruAHLwCg3kmqh1Yb/RGGw8tHxSDHYGUAv1R SsImD26DPEQ20DWW9wy8Pz0Deev0sn56ROEtJKAAjIomtuZxGthTfqrvAIm+Ko8ggrgF5 HbYlr4yhPxNJWiFgCPtI3JdthX+geMkffH7VqLQQlIyKzOWSriXIz5/fw8VHagBgVHw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=Vx4J4G9N; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39DE3606A32C; Sat, 7 Nov 2026 14:55:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 39DE3606A32C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=Vx4J4G9N DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=9fZSnTYT8MA9EbRBaUvLqKYLQu5iORlXOvx+G3Uf2Jc=; b=Vx4J4G9No9bGRJ4Vs0GPjrqjeT ToMpI2Vl+Ww2kkw+zMNU1/iDDpUDu3YRotlBkpj9gKNB74bBHTypCnSy/xC6d1DK5LDIQooU3Vn91 o6AcmQvggAkz/uvzI1jyu03Km0tXEYX8qPdITP2+kuMINdoUeyob16qSdX45z4wObi5ieN66BW4ue BlgYsfBOIb2JOxJ6hUKlbwpjiJbWc7qZq7ZNfsQWKZFAPa6g2PANLncMplYImLQAgsqbMNE5yxtfy EccGTLdNgh9J4QLQXaN9VRoPbwqYorjGX0D+jkVxeA1ntzsyI4FcN8YGopY6zSra3Nd5Q2S7OUulz BvedVQwA==; From: Heiko Stuebner To: rafael@kernel.org, Daniel Lezcano Cc: Daniel Lezcano , Shuah Khan , Manaf Meethalavalappu Pallikunhi , Lukasz Luba , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 4/6] powercap: dtpm: Use generic powercap hierarchy helpers Date: Sat, 07 Nov 2026 15:55:14 +0100 Message-ID: <4204877.2iPT33SAM4@phil> In-Reply-To: References: X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Am Dienstag, 3. November 2026, 05:48:18 Mitteleurop=C3=A4ische Normalzeit s= chrieb Daniel Lezcano: > DTPM implements its own hierarchy creation and destruction logic while > the powercap core now provides generic helpers for this purpose. >=20 > Convert DTPM to use the generic powercap hierarchy infrastructure. > Duplicate the platform hierarchy before creating it, and use > powercap_hierarchy_create() and powercap_hierarchy_destroy() to manage > the DTPM zones. >=20 > Add DTPM callbacks to create and destroy the zones associated with each > powercap hierarchy node. Adapt the CPU and devfreq backends to return > the created DTPM instance and use the node name provided by the > hierarchy. >=20 > Convert the Rockchip RK3399 description to struct powercap_hierarchy > and keep the device tree path as DTPM-specific node data. >=20 > This removes the DTPM-specific hierarchy traversal and destruction code > and leaves the hierarchy management to the powercap core. >=20 > Preserve best-effort creation: an unavailable backend returns NULL to > skip its branch, and setup failures are warned about and skipped rather > than rolling back independent zones. Invalid node descriptors remain > fatal. Reject a DT node with a NULL path before calling > of_find_node_by_path(), treating it as an invalid descriptor rather > than an unavailable backend. >=20 > When the representative CPU is offline, find an active policy through an > online sibling whose related_cpus mask contains it. Hold the CPU hotplug > read lock during selection and setup, and initialize the zone through the > policy's active CPU while keeping the hierarchy-provided name. An entirely > offline policy still has no active CPU to initialize through. >=20 > Signed-off-by: Daniel Lezcano > --- > Changes in v5 (since v4): > - Reject a NULL DT node path with -EINVAL before invoking > dtpm_setup_dt(), as suggested by Lukasz Luba. > - Document that a missing path is an invalid hierarchy descriptor. >=20 > Changes in v4 (since v3): > - Rebase on v7.3; no code or commit-description changes. >=20 > Changes in v3 (since v2): > - Rebase on v7.3-rc7. > - Preserve best-effort branch creation using the generic NULL result. > - Find an online policy sibling for offline CPU representatives and > protect policy selection and setup against CPU hotplug. > - Keep generic API behavior and documentation in patch 1. > - Fix __initdata placement; match-table indentation is handled in patch 3. > - Name setup callback arguments and remove whitespace-only lines. > - Update the description. >=20 > drivers/powercap/dtpm.c | 180 +++++++++++++++----------------- > drivers/powercap/dtpm_cpu.c | 62 ++++++++--- > drivers/powercap/dtpm_devfreq.c | 22 ++-- > drivers/soc/rockchip/dtpm.c | 67 +++++++++--- > include/linux/dtpm.h | 6 +- > 5 files changed, 198 insertions(+), 139 deletions(-) I tried to follow along and the changes look ok, but I don't know the more intricate details, so Acked-by: Heiko Stuebner