Samuel Jean wrote:

> I don't know if this patch breaks something, but at least am sure of 
> something:
>
> Into ip_tables.h, DECLARE_MUTEX is used outside of __KERNEL__ 
> compilation.
> However, DECLARE_MUTEX exists only when #ifdef __KERNEL__
> according to asm/.../semaphore.h.
>
> I couldn't track when and why this semaphore had been introduced, but 
> linux-2.4.26
> for sure doesn't use it.


======== include/linux/netfilter_ipv4/ip_tables.h 1.1..1.5 ========
D 1.5 04/06/06 20:13:18-07:00 hadi@zynx.com 6 5 8/0/447
P include/linux/netfilter_ipv4/ip_tables.h
C [NETFILTER]: Small interface cleanup for {ipt,ip6t,arpt}_find_target.

It seems that Jamal introduced this as a clean up some time ago. Maybe 
because of an leftover intention of pushing forward ipt action in 2.4 ?

Anyway, I didn't find any client of ipt_mutex. I think it's better if we 
move it to its original place, ip_tables.c.

--
Pablo