All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rojhalat Ibrahim <ibrahim@schenk.isar.de>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: More than 512MB of memory
Date: Tue, 08 Feb 2005 10:57:14 +0100	[thread overview]
Message-ID: <42088CFA.6090605@schenk.isar.de> (raw)
In-Reply-To: <20050208001742.GA15336@linux-mips.org>

Ralf Baechle wrote:
> 
> Blowing away the entire S-cache is extreme overkill.  We really want to
> avoid this if possible as it'll have serious performance impact.  As for
> the RM9000 that means we have a struct page pointer, therefore we know
> the physical address of the page and can perform a selective flush on the
> second level cache.  See below for a patch which tries that.
> 
> Obviously this one only tries to optimize performance a bit further but
> doesn't really solve the remaining problem.
> 
>   Ralf
> 
> Index: arch/mips/mm/c-r4k.c
> ===================================================================
> RCS file: /home/cvs/linux/arch/mips/mm/c-r4k.c,v
> retrieving revision 1.101
> diff -u -r1.101 c-r4k.c
> --- arch/mips/mm/c-r4k.c	7 Feb 2005 21:53:39 -0000	1.101
> +++ arch/mips/mm/c-r4k.c	8 Feb 2005 00:18:17 -0000
> @@ -566,9 +566,21 @@
>  
>  	if (!cpu_has_ic_fills_f_dc) {
>  		unsigned long addr = (unsigned long) page_address(page);
> -		r4k_blast_dcache_page(addr);
> -		if (!cpu_icache_snoops_remote_store)
> -			r4k_blast_scache_page(addr);
> +
> +		if (addr)
> +			r4k_blast_dcache_page(addr);
> +		else
> +			r4k_blast_dcache();
> +
> +		if (!cpu_icache_snoops_remote_store) {
> +			if (addr)
> +				r4k_blast_scache_page(addr);
> +			else {
> +				addr = page_to_pfn(page) << PAGE_SHIFT;
> +				addr = CKSEG + (addr & ~((1UL << 24) - 1));
> +				r4k_blast_scache_page_indexed(addr);
> +			}
> +		}
>  		ClearPageDcacheDirty(page);
>  	}
>  
> 

I presume CKSEG is CKSEG0 in the above patch. With that it works
about the same as before. So do you have any clue what the problem
behind all that really is? Furthermore I still have all those
"Illegal instruction" and "Segmentation fault" messages that
shouldn't be there.

Thanks
Rojhalat Ibrahim

  reply	other threads:[~2005-02-08  9:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-18 14:44 More than 512MB of memory Rojhalat Ibrahim
2005-01-18 15:49 ` Manish Lachwani
2005-01-18 17:13   ` Rojhalat Ibrahim
2005-02-03 15:35 ` Ralf Baechle
2005-02-03 18:20   ` Manish Lachwani
2005-02-04  0:01     ` Ralf Baechle
2005-02-04  0:40 ` Ralf Baechle
2005-02-07  8:10   ` Rojhalat Ibrahim
2005-02-08  0:17     ` Ralf Baechle
2005-02-08  9:57       ` Rojhalat Ibrahim [this message]
2005-02-09  0:06         ` Ralf Baechle
2005-02-09  8:06           ` Rojhalat Ibrahim
2005-02-10 13:40             ` Ralf Baechle
2005-02-10 14:54               ` Rojhalat Ibrahim
2005-02-10 15:10               ` Rojhalat Ibrahim
2005-02-09 15:41         ` Rojhalat Ibrahim
2005-02-09 18:14           ` Ralf Baechle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42088CFA.6090605@schenk.isar.de \
    --to=ibrahim@schenk.isar.de \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.