Re: [PATCH] kernel: Clean up generated syscall_entries.h file

[Richard Weinberger <richard@sigma-star.at>]

Am Donnerstag, 27. Juni 2024, 08:29:46 CEST schrieb 'Jan Kiszka' via upstream:
> > @@ -31,7 +31,7 @@ quiet_cmd_syscall_entries = GEN     $@
> >  $(obj)/syscall_entries.h: $(syscall_entries) $(wildcard $(srctree)/$(src)/*.c) FORCE
> >  	$(call if_changed,syscall_entries)
> >  
> > -target += syscall_entries.h
> > +clean-files += syscall_entries.h
> 
> target is generally needed to prevent re-executing the build although
> that target file is already present and recent. Did you check that a
> second build will not have this problem after that change?

I thought you want re-executing because of the "FORCE" property.
Why is FORCE needed then?

Why doesn't the "default" maineline work?
e.g. something like that:
diff --git a/kernel/cobalt/posix/Makefile b/kernel/cobalt/posix/Makefile
index 5b4f3214a..e57628cf1 100644
--- a/kernel/cobalt/posix/Makefile
+++ b/kernel/cobalt/posix/Makefile
@@ -26,13 +26,13 @@ xenomai-y :=                \
 syscall_entries := $(srctree)/$(src)/gen-syscall-entries.sh
 
 quiet_cmd_syscall_entries = GEN     $@
-      cmd_syscall_entries = $(CONFIG_SHELL) '$(syscall_entries)' $(filter-out FORCE,$^) > $@
+      cmd_syscall_entries = $^ > $@
 
-$(obj)/syscall_entries.h: $(syscall_entries) $(wildcard $(srctree)/$(src)/*.c) FORCE
-       $(call if_changed,syscall_entries)
-
-target += syscall_entries.h
+$(obj)/syscall_entries.h: $(syscall_entries) $(wildcard $(srctree)/$(src)/*.c)
+       $(call cmd,syscall_entries)
 
 $(obj)/syscall.o: $(obj)/syscall_entries.h
 
+clean-files    += syscall_entries.h
+
 xenomai-$(CONFIG_XENO_ARCH_SYS3264) += compat.o syscall32.o

LG,
//richard

-- 
​​​​​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT
UID/VAT Nr: ATU 66964118 | FN: 374287y