All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Jean <sj-netfilter@cookinglinux.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Harald Welte <laforge@netfilter.org>, jamal <hadi@cyberus.ca>,
	netfilter-devel@lists.netfilter.org,
	Pablo Neira <pablo@eurodev.net>, John Hill <jhill@noach.com>
Subject: [PATCH] DECLARE_MUTEX in ip6_tables.h just like ip_tables.h
Date: Tue, 08 Feb 2005 16:51:39 -0500	[thread overview]
Message-ID: <4209346B.5020100@cookinglinux.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0502080751120.32526@kaber.coreworks.de>

Patrick McHardy wrote:
> On Tue, 8 Feb 2005, Pablo Neira wrote:
> 
>> Anyway, I didn't find any client of ipt_mutex. I think it's better if 
>> we move it to its original place, ip_tables.c.
> 
> 
> Agreed, we already got rid of this in 2.6. I've applied your patch,
> thanks.
> 
> Regards
> Patrick
> 

John Hill pointed out the same happens on libip6t* libraries compilation time.

Here's a patch like Pablo's ip_tables.h one.

Regards,
Samuel

Signed-off-by: Samuel Jean <sjean@cookinglinux.org>

diff -ur linux-2.4.29-bk8/include/linux/netfilter_ipv6/ip6_tables.h 
linux-2.4.29-bk8-patched/include/linux/netfilter_ipv6/ip6_tables.h
--- linux-2.4.29-bk8/include/linux/netfilter_ipv6/ip6_tables.h  2004-08-07 19:26:06.000000000 -0400
+++ linux-2.4.29-bk8-patched/include/linux/netfilter_ipv6/ip6_tables.h  2005-02-08 
16:37:40.000000000 -0500
@@ -106,8 +106,6 @@
         u_int64_t pcnt, bcnt;                   /* Packet and byte counters */
  };

-static DECLARE_MUTEX(ip6t_mutex);
-
  /* Values for "flag" field in struct ip6t_ip6 (general ip6 structure). */
  #define IP6T_F_PROTO           0x01    /* Set if rule cares about upper
                                            protocols */
diff -ur linux-2.4.29-bk8/net/ipv6/netfilter/ip6_tables.c 
linux-2.4.29-bk8-patched/net/ipv6/netfilter/ip6_tables.c
--- linux-2.4.29-bk8/net/ipv6/netfilter/ip6_tables.c    2005-01-19 09:10:14.000000000 -0500
+++ linux-2.4.29-bk8-patched/net/ipv6/netfilter/ip6_tables.c    2005-02-08 16:38:35.000000000 -0500
@@ -58,6 +58,7 @@
  #endif
  #define SMP_ALIGN(x) (((x) + SMP_CACHE_BYTES-1) & ~(SMP_CACHE_BYTES-1))

+static DECLARE_MUTEX(ip6t_mutex);

  /* Must have mutex */
  #define ASSERT_READ_LOCK(x) IP_NF_ASSERT(down_trylock(&ip6t_mutex) != 0)

  reply	other threads:[~2005-02-08 21:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-07 15:52 [Fwd: RE: Second Request for help!!] Samuel Jean
2005-02-07 23:52 ` [POSSIBLE PATCH] DECLARE_MUTEX while not in __KERNEL__ (Was: Re: [Fwd: RE: Second Request for help!!]) Samuel Jean
2005-02-08  0:17   ` Pablo Neira
2005-02-08  6:54     ` Patrick McHardy
2005-02-08 21:51       ` Samuel Jean [this message]
2005-02-08 23:02         ` [PATCH] DECLARE_MUTEX in ip6_tables.h just like ip_tables.h Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4209346B.5020100@cookinglinux.org \
    --to=sj-netfilter@cookinglinux.org \
    --cc=hadi@cyberus.ca \
    --cc=jhill@noach.com \
    --cc=kaber@trash.net \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@eurodev.net \
    --cc=sjean@cookinglinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.