From: Tejun Heo <htejun@gmail.com>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [rfc][patch] ide: fix unneeded LBA48 taskfile registers access
Date: Thu, 10 Feb 2005 09:52:25 +0900 [thread overview]
Message-ID: <420AB049.4040705@gmail.com> (raw)
In-Reply-To: <58cb370e050209162437808733@mail.gmail.com>
Okay, another quick question.
To fix the io_32bit race problem in ide_taskfile_ioctl() (and later
ide_cmd_ioctl() too), it seems simplest to mark the taskfile with
something like ATA_TFLAG_IO_16BIT flag and use the flag in task_in_intr().
However, ATA_TFLAG_* are used by libata, and I think that, although
sharing hardware constants is good if the hardware is similar, sharing
driver-specific flags isn't such a good idea. So, what do you think?
1. Add ATA_TFLAG_IO_16BIT to ata.h
2. Make ide's own set of task flags, maybe IDE_TFLAG_* (including
IDE_TFLAG_LBA48)
--
tejun
next prev parent reply other threads:[~2005-02-10 0:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-06 22:54 [rfc][patch] ide: fix unneeded LBA48 taskfile registers access Bartlomiej Zolnierkiewicz
2005-02-07 4:47 ` Tejun Heo
2005-02-07 8:58 ` Jeff Garzik
2005-02-07 8:59 ` Bartlomiej Zolnierkiewicz
2005-02-10 0:01 ` Tejun Heo
2005-02-10 0:24 ` Bartlomiej Zolnierkiewicz
2005-02-10 0:52 ` Tejun Heo [this message]
2005-02-10 1:31 ` Bartlomiej Zolnierkiewicz
2005-02-10 2:04 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=420AB049.4040705@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.