Re: [PATCH 2/5] sonypi: add another HELP button event

["Daniel K." <dk@cluded.net>]

Stelian Pop wrote:
> ===================================================================
> 
> Add another HELP button event.
> Increment the version number.
> 

> 
> Index: drivers/char/sonypi.h
> ===================================================================
> --- a/drivers/char/sonypi.h	(revision 26539)
> +++ b/drivers/char/sonypi.h	(revision 26540)

> @@ -330,6 +330,7 @@ struct sonypi_eventtypes {
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_PKEY_MASK, sonypi_pkeyev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x11, SONYPI_BACK_MASK, sonypi_backev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x08, SONYPI_HELP_MASK, sonypi_helpev },
> +	{ SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_HELP_MASK, sonypi_helpev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x21, SONYPI_ZOOM_MASK, sonypi_zoomev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x20, SONYPI_THUMBPHRASE_MASK, sonypi_thumbphraseev },
>  	{ SONYPI_DEVICE_MODEL_TYPE2, 0x31, SONYPI_MEMORYSTICK_MASK, sonypi_memorystickev },

I suspect you should simply replace the '0x08' line as it was left over
from my earlier patch introducing EVTYPE_OFFSET. At that time all the
values were 0x08, most was updated, but a few were not, due to
unsuficcient data.

Daniel K.