All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] kj-devel.pl
Date: Thu, 10 Feb 2005 21:34:00 +0000	[thread overview]
Message-ID: <420BD348.4020300@osdl.org> (raw)
In-Reply-To: <f0cb4a32050131113478b2ec2b@mail.gmail.com>

> 
> The second script it's just the removal of strlen and sprintf checks, I'll be 
> adding some more things to this.

Here are a few more false reports, if you are interested, from the 
linux/ipc/ directory:

Should be return -E ?mqueue.c:1453:			return ERR_PTR(-EFAULT);
Should be return -E ?mqueue.c:1455:			return ERR_PTR(-EINVAL);
Should be return -E ?mqueue.c:1463:		return ERR_PTR(ret);
Should be return -E ?mqueue.c:1480:		return ERR_PTR(-EINVAL);
Should be return -E ?mqueue.c:1483:		return ERR_PTR(-EACCES);
Should be return -E ?msg.c:1453:			return ERR_PTR(-EFAULT);
Should be return -E ?msg.c:1455:			return ERR_PTR(-EINVAL);
Should be return -E ?msg.c:1463:		return ERR_PTR(ret);
Should be return -E ?msg.c:1480:		return ERR_PTR(-EINVAL);
Should be return -E ?msg.c:1483:		return ERR_PTR(-EACCES);


and some good ones:

Bad. Should use set_current_state.
msg.c:2230:	current->state=TASK_INTERRUPTIBLE;

Bad. Should use set_current_state.
msg.c:2836:		current->state = TASK_INTERRUPTIBLE;


Any idea what this message means?

Unmatched ) in regex; marked by <-- HERE in m/spin_unlock.*) <-- HERE 
  inside ipc_lock_by_ptr(/ at /home/rddunlap/scripts/kj-devel-vic2.pl 
line 61.


 From the linux/lib/ directory, I am seeing comment lines not being
skipped:

strtok() is racy on smp, use strsep() instead.
string.c:7440: * -  Added strsep() which will replace strtok() soon 
(because strsep() is

strtok() is racy on smp, use strsep() instead.
string.c:7445: * -  Kissed strtok() goodbye

strtok() is racy on smp, use strsep() instead.
vsprintf.c:7440: * -  Added strsep() which will replace strtok() soon 
(because strsep() is

strtok() is racy on smp, use strsep() instead.
vsprintf.c:7445: * -  Kissed strtok() goodbye

-- 
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2005-02-10 21:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-31 19:34 [KJ] kj-devel.pl Vicente Feito
2005-02-07 23:35 ` Randy.Dunlap
2005-02-08  7:57 ` Vicente Feito
2005-02-10 21:34 ` Randy.Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=420BD348.4020300@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.