All of lore.kernel.org
 help / color / mirror / Atom feed
From: Badari Pulavarty <pbadari@us.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: ext2-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org,
	sct@redhat.com
Subject: Re: [RFC] ext3 writepages for writeback mode
Date: Thu, 10 Feb 2005 19:06:18 -0800	[thread overview]
Message-ID: <420C212A.6090800@us.ibm.com> (raw)
In-Reply-To: <20050210175327.7b4a508b.akpm@osdl.org>

Andrew Morton wrote:
> Badari Pulavarty <pbadari@us.ibm.com> wrote:
> 
>> Here is my first cut at adding writepages() support for
>> ext3 writeback mode.
> 
> 
> Looks sane from a brief scan.

Well, not really..

mpage_writepages() could end up calling ext3_writeback_writepage()
in "confused" case thro ..

	*ret = page->mapping->a_ops->writepage(page, wbc);

which ends up doing nothing and leaves the page dirty, since there is 
journal handle started :(

	if (ext3_journal_current_handle())
		goto out_fail;

Ideas ?

Thanks,
Badari

  reply	other threads:[~2005-02-11  3:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-11  1:31 [RFC] ext3 writepages for writeback mode Badari Pulavarty
2005-02-11  1:53 ` Andrew Morton
2005-02-11  3:06   ` Badari Pulavarty [this message]
2005-02-11 23:29   ` Badari Pulavarty
2005-02-11 23:58     ` Andrew Morton
2005-02-12  0:09       ` Badari Pulavarty
2005-02-14 20:02         ` Sonny Rao
2005-02-14 20:22           ` [Ext2-devel] " Sonny Rao
2005-02-12  0:51       ` Badari Pulavarty
2005-02-12  1:00         ` Andrew Morton
2005-02-12  1:55           ` Badari Pulavarty
2005-02-12 12:20         ` [Ext2-devel] " Alex Tomas
2005-02-12 18:47           ` Badari Pulavarty
2005-02-12 21:43             ` Alex Tomas
2005-02-12 23:26           ` Badari Pulavarty
2005-02-12 23:29             ` Alex Tomas
2005-02-14 15:58               ` Badari Pulavarty
2005-02-14 16:34                 ` Alex Tomas
2005-02-14 16:50 ` Thiago Rondon
2005-02-14 18:08   ` Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=420C212A.6090800@us.ibm.com \
    --to=pbadari@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.