just my two cents ...
recruting helper variables will reduce linelenght and (sometimes) 
improve readability.

e.g.:

feature=tf->feature | (((u16)tf->hob_feature) << 8 ;

writew(feature,(volatile void __iomem *)ioaddr->feature_addr);


btw:
is 'volatile' usefull here ? i would exspect that *ioaddr->feature_addr
is already defined 'volatile'.
( i do not have the code here, sorry if its to trivial.)

re,
	walter



4.  		writew(tf->feature | (((u16)tf->hob_feature) << 8), (volatile
void __iomem *)ioaddr->feature_addr);

This line (and others) is just too long.  Split it up at the comma
between the first & second parameters and then indent the second
line.


-- 
~Randy
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors