Re: [PATCH] kill NFC_* stuff in iptables [was Re: iptables compile error: NFC_IP_TOS undeclared]

[Patrick McHardy <kaber@trash.net>]

Pablo Neira wrote:

> Patrick McHardy wrote:
>
>> I haven't actually checked
>> the API, but can't we remove all those now empty init functions ?
>> If not I think it would be nicer to change the API to check for
>> ->init == NULL instead of leaving all these empty funtion bodies around.
>
> Yes, I agree and I did it, I must confess that it was kinda boring a 
> bit. See the patch attached.

Thanks Pablo. I'm going to apply it once iptables 1.3.0 is released.

>> I don't think we can remove it from struct ipt_entry without
>> breaking userspace compatibility. But we could stop using it.
>
> Yes, I was aware of that :). I didn't talk about modifying ipt_entry 
> which is not possible because of backward compatibility. I mean that, 
> as next step, we could kill those nfcache arguments passed as 
> parameter that aren't useful anymore.

Sure, go ahead.

Regards
Patrick