From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0192C6FA86 for ; Mon, 12 Sep 2022 13:38:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7FAC10E4DB; Mon, 12 Sep 2022 13:38:16 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBF4010E7A7; Wed, 7 Sep 2022 15:09:08 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id u9so31109874ejy.5; Wed, 07 Sep 2022 08:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=PsSk7c5ChVk3DJTul0PslXYL3Ii3rxu7S+9k3ZdWO7J5+Rg3SJKW/GHR+l1IdCcqbD QzOSg+X20xKhDWwzVNp1EVZBeuM2og/eiCkM9VRatVBVuKtFUtC1IFd6TnphWbjqABrV lPI8ekc2MCGq7SaNBqXRHV/YntEXs/I2px8KM7Uiih87ZHZU+6OWWEzoS4qPY0Dysev9 Kf1PW1ximX/Nir+q+GFzRH9fkY+Yz9NccxBJ97dIkXFYKX6Fbwdx2rSEm5fgP9TwN8TP Yn0/K6m8BPkKDGCZQYLjYFkzq7AqD2/EwCvermdk+S+d7m7gCF9XDJd4z+oxXRFK59CM CsMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=I/kCHXxfRBGEPyaz5IeFZPqXIoVuZYzsc6rXxxYpKvS7iQFjap2j0JuBePDa0EZMe8 m67qRwnG4VEeU/iLQy/y5+kBZiXWCNIAk17IvdUswIKqmC7viihFqSlaolJ1oK0kg088 oItWZ470qiq9brjOjLIPb+zlTqCOZaVuxnwYEcoPKrA4qyZFxHgBxl8ZCgyJ8hIgTJpM iR/3Mv9ZglaEo48QG4O4YDKHmTjscqxkO0cTPnpslojDX29wtvcRHtUWkJz5XWl6YHAq yt0Z7AEo0XZqJ/Z8jCvfdz3fpaVp9ie71BOUdveXZJJ7qoyCiUE/BMt5Bipc1gy4tjXa u6XQ== X-Gm-Message-State: ACgBeo0THWwmEqoLcSHQeca4+EZ0iFkk3vNIW0eipxxU3glmWslvBNu3 brNgFhsrUL6t/E90Vg5mTLI= X-Google-Smtp-Source: AA6agR7+yo4NVJ1b3xBSrgRyiVKs02kmJQtjtA3mve9GOkmdtQU6KrWKBuLTC8Uj3eslmjookwi2Eg== X-Received: by 2002:a17:907:7d8e:b0:742:8ea0:686c with SMTP id oz14-20020a1709077d8e00b007428ea0686cmr2603244ejc.591.1662563347199; Wed, 07 Sep 2022 08:09:07 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id p23-20020a056402501700b0043ba7df7a42sm10858179eda.26.2022.09.07.08.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 08:09:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Date: Wed, 07 Sep 2022 17:09:04 +0200 Message-ID: <4210281.ejJDZkT8p0@kista> In-Reply-To: <20220907074134.36yysxrnnpty4ngw@houat> References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <10138422.nUPlyArG6x@kista> <20220907074134.36yysxrnnpty4ngw@houat> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Mon, 12 Sep 2022 13:38:08 +0000 Subject: Re: [Intel-gfx] [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , David Airlie , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Phil Elwell , Emma Anholt , Samuel Holland , Chen-Yu Tsai , Geert Uytterhoeven , Ben Skeggs , linux-sunxi@lists.linux.dev, Thomas Zimmermann , intel-gfx@lists.freedesktop.org, Rodrigo Vivi , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Dom Cobley , Dave Stevenson , linux-kernel@vger.kernel.org, Mateusz Kwiatkowski , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Philipp Zabel Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Dne sreda, 07. september 2022 ob 09:41:34 CEST je Maxime Ripard napisal(a): > On Tue, Sep 06, 2022 at 10:04:32PM +0200, Jernej =C5=A0krabec wrote: > > Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard=20 napisal(a): > > > Our mode_set implementation can be merged into our atomic_enable > > > implementation to simplify things, so let's do this. > >=20 > > Are you sure this is a good thing in long term? What if user wants to > > change mode? Unlikely, but why not. >=20 > It doesn't change anything feature-wise: whenever the mode is changed on > the CRTC, the encoder is going to be disabled and enabled. >=20 > It's disabled here: > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic= _he > lper.c#L1064 >=20 > And enabled here: > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic= _he > lper.c#L1403 >=20 > With drm_atomic_crtc_needs_modeset() being defined here: > https://elixir.bootlin.com/linux/latest/source/include/drm/drm_atomic.h#L= 104 > 9 Right. Acked-by: Jernej Skrabec Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BF125CA6 for ; Wed, 7 Sep 2022 15:09:08 +0000 (UTC) Received: by mail-ej1-f47.google.com with SMTP id dv25so1800135ejb.12 for ; Wed, 07 Sep 2022 08:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=PsSk7c5ChVk3DJTul0PslXYL3Ii3rxu7S+9k3ZdWO7J5+Rg3SJKW/GHR+l1IdCcqbD QzOSg+X20xKhDWwzVNp1EVZBeuM2og/eiCkM9VRatVBVuKtFUtC1IFd6TnphWbjqABrV lPI8ekc2MCGq7SaNBqXRHV/YntEXs/I2px8KM7Uiih87ZHZU+6OWWEzoS4qPY0Dysev9 Kf1PW1ximX/Nir+q+GFzRH9fkY+Yz9NccxBJ97dIkXFYKX6Fbwdx2rSEm5fgP9TwN8TP Yn0/K6m8BPkKDGCZQYLjYFkzq7AqD2/EwCvermdk+S+d7m7gCF9XDJd4z+oxXRFK59CM CsMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=KQ3vjnx6AaXqDQZ4gxJHAfXn5bBXRCK1385HBRv1FMYfKLHim/nfyypsg2cXTrszRX f+A5aufrJV6Mw2Sa1TXTsRb90/n6yrQD7mf0hLRfHxKDB2SYd6os4W0Ff0HafQDuzNiQ TQge7wgIc1gUpD4p8etu+1j+XA+PaosT1sNOBu622HDRlUjNhJsNzI0vRV4PJnGOtlnm dMMkzw6jZ921MCTXo+yhnb/A1w8s7EcKil7dTx2FkdGsTQxGQum90P908SDZ4eeBn/My Q22lqbTa9WSViTi60yFviaS/rUxio5LPtboMsRgpkxuDoTjdPd8O6ZVAPiR4bw6CZaU5 dXVA== X-Gm-Message-State: ACgBeo2PwIgYG5r1tpZckd9Xsn/gLxJvKbphQPrBpuYFWSyQmXfdWfti rbraRiNfUtO5zhCbmOz4Nfc= X-Google-Smtp-Source: AA6agR7+yo4NVJ1b3xBSrgRyiVKs02kmJQtjtA3mve9GOkmdtQU6KrWKBuLTC8Uj3eslmjookwi2Eg== X-Received: by 2002:a17:907:7d8e:b0:742:8ea0:686c with SMTP id oz14-20020a1709077d8e00b007428ea0686cmr2603244ejc.591.1662563347199; Wed, 07 Sep 2022 08:09:07 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id p23-20020a056402501700b0043ba7df7a42sm10858179eda.26.2022.09.07.08.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 08:09:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Cc: Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Samuel Holland , Karol Herbst , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Hans de Goede , linux-arm-kernel@lists.infradead.org, Phil Elwell , intel-gfx@lists.freedesktop.org, Dave Stevenson , dri-devel@lists.freedesktop.org, Dom Cobley , linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski , Geert Uytterhoeven Subject: Re: Re: [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable Date: Wed, 07 Sep 2022 17:09:04 +0200 Message-ID: <4210281.ejJDZkT8p0@kista> In-Reply-To: <20220907074134.36yysxrnnpty4ngw@houat> References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <10138422.nUPlyArG6x@kista> <20220907074134.36yysxrnnpty4ngw@houat> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Dne sreda, 07. september 2022 ob 09:41:34 CEST je Maxime Ripard napisal(a): > On Tue, Sep 06, 2022 at 10:04:32PM +0200, Jernej =C5=A0krabec wrote: > > Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard=20 napisal(a): > > > Our mode_set implementation can be merged into our atomic_enable > > > implementation to simplify things, so let's do this. > >=20 > > Are you sure this is a good thing in long term? What if user wants to > > change mode? Unlikely, but why not. >=20 > It doesn't change anything feature-wise: whenever the mode is changed on > the CRTC, the encoder is going to be disabled and enabled. >=20 > It's disabled here: > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic= _he > lper.c#L1064 >=20 > And enabled here: > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic= _he > lper.c#L1403 >=20 > With drm_atomic_crtc_needs_modeset() being defined here: > https://elixir.bootlin.com/linux/latest/source/include/drm/drm_atomic.h#L= 104 > 9 Right. Acked-by: Jernej Skrabec Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0AA06C54EE9 for ; Wed, 7 Sep 2022 15:09:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F50610E7A4; Wed, 7 Sep 2022 15:09:11 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBF4010E7A7; Wed, 7 Sep 2022 15:09:08 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id u9so31109874ejy.5; Wed, 07 Sep 2022 08:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=PsSk7c5ChVk3DJTul0PslXYL3Ii3rxu7S+9k3ZdWO7J5+Rg3SJKW/GHR+l1IdCcqbD QzOSg+X20xKhDWwzVNp1EVZBeuM2og/eiCkM9VRatVBVuKtFUtC1IFd6TnphWbjqABrV lPI8ekc2MCGq7SaNBqXRHV/YntEXs/I2px8KM7Uiih87ZHZU+6OWWEzoS4qPY0Dysev9 Kf1PW1ximX/Nir+q+GFzRH9fkY+Yz9NccxBJ97dIkXFYKX6Fbwdx2rSEm5fgP9TwN8TP Yn0/K6m8BPkKDGCZQYLjYFkzq7AqD2/EwCvermdk+S+d7m7gCF9XDJd4z+oxXRFK59CM CsMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=I/kCHXxfRBGEPyaz5IeFZPqXIoVuZYzsc6rXxxYpKvS7iQFjap2j0JuBePDa0EZMe8 m67qRwnG4VEeU/iLQy/y5+kBZiXWCNIAk17IvdUswIKqmC7viihFqSlaolJ1oK0kg088 oItWZ470qiq9brjOjLIPb+zlTqCOZaVuxnwYEcoPKrA4qyZFxHgBxl8ZCgyJ8hIgTJpM iR/3Mv9ZglaEo48QG4O4YDKHmTjscqxkO0cTPnpslojDX29wtvcRHtUWkJz5XWl6YHAq yt0Z7AEo0XZqJ/Z8jCvfdz3fpaVp9ie71BOUdveXZJJ7qoyCiUE/BMt5Bipc1gy4tjXa u6XQ== X-Gm-Message-State: ACgBeo0THWwmEqoLcSHQeca4+EZ0iFkk3vNIW0eipxxU3glmWslvBNu3 brNgFhsrUL6t/E90Vg5mTLI= X-Google-Smtp-Source: AA6agR7+yo4NVJ1b3xBSrgRyiVKs02kmJQtjtA3mve9GOkmdtQU6KrWKBuLTC8Uj3eslmjookwi2Eg== X-Received: by 2002:a17:907:7d8e:b0:742:8ea0:686c with SMTP id oz14-20020a1709077d8e00b007428ea0686cmr2603244ejc.591.1662563347199; Wed, 07 Sep 2022 08:09:07 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id p23-20020a056402501700b0043ba7df7a42sm10858179eda.26.2022.09.07.08.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 08:09:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Date: Wed, 07 Sep 2022 17:09:04 +0200 Message-ID: <4210281.ejJDZkT8p0@kista> In-Reply-To: <20220907074134.36yysxrnnpty4ngw@houat> References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <10138422.nUPlyArG6x@kista> <20220907074134.36yysxrnnpty4ngw@houat> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [Nouveau] [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, Joonas Lahtinen , dri-devel@lists.freedesktop.org, Phil Elwell , Emma Anholt , Samuel Holland , Chen-Yu Tsai , Geert Uytterhoeven , Ben Skeggs , linux-sunxi@lists.linux.dev, intel-gfx@lists.freedesktop.org, Maarten Lankhorst , Jani Nikula , Hans de Goede , Rodrigo Vivi , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Tvrtko Ursulin , Dom Cobley , linux-kernel@vger.kernel.org, Mateusz Kwiatkowski , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Philipp Zabel Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" Dne sreda, 07. september 2022 ob 09:41:34 CEST je Maxime Ripard napisal(a): > On Tue, Sep 06, 2022 at 10:04:32PM +0200, Jernej =C5=A0krabec wrote: > > Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard=20 napisal(a): > > > Our mode_set implementation can be merged into our atomic_enable > > > implementation to simplify things, so let's do this. > >=20 > > Are you sure this is a good thing in long term? What if user wants to > > change mode? Unlikely, but why not. >=20 > It doesn't change anything feature-wise: whenever the mode is changed on > the CRTC, the encoder is going to be disabled and enabled. >=20 > It's disabled here: > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic= _he > lper.c#L1064 >=20 > And enabled here: > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic= _he > lper.c#L1403 >=20 > With drm_atomic_crtc_needs_modeset() being defined here: > https://elixir.bootlin.com/linux/latest/source/include/drm/drm_atomic.h#L= 104 > 9 Right. Acked-by: Jernej Skrabec Best regards, Jernej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D47C3C38145 for ; Wed, 7 Sep 2022 15:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vJp7CojTtABuoym7b1qDlgv3W3oZc8EDp51le4GuNn8=; b=uXPoiioIiCMhn6 UNQBJP5ClatBdHEgEH3ohPzFqoQSqfQO7i8SYjFY4j/9d7FghJHDEIsKMqMeFBqxa7ayb+M6Pytah qdEkzFaw3BECh2HFoFERFnGSmZOKVNsNNV8Dm3X+iqwIeZm+yKtV2ElK+5HtnOGrGpQ1LTJ9PojgQ Qj6rjjEIftCqIkYhPDcE2oJ6gh4p/eADDJfOV2lFmXuiTLa5y2un8uTwt18bWIlAxCENb6Tw8Hj84 JP543LTbR/XJ5jNokOzKJAx4ZscpjP+zdea0hhlIsF75hsXFDt+BVYXMGJpYYSBsvOa50RvA3XjNl ta1aBS1K8Ndy+vDR63Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVwfx-007EUY-Tg; Wed, 07 Sep 2022 15:09:14 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oVwfu-007EQb-Vy for linux-arm-kernel@lists.infradead.org; Wed, 07 Sep 2022 15:09:12 +0000 Received: by mail-ej1-x62d.google.com with SMTP id gh9so9168392ejc.8 for ; Wed, 07 Sep 2022 08:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=PsSk7c5ChVk3DJTul0PslXYL3Ii3rxu7S+9k3ZdWO7J5+Rg3SJKW/GHR+l1IdCcqbD QzOSg+X20xKhDWwzVNp1EVZBeuM2og/eiCkM9VRatVBVuKtFUtC1IFd6TnphWbjqABrV lPI8ekc2MCGq7SaNBqXRHV/YntEXs/I2px8KM7Uiih87ZHZU+6OWWEzoS4qPY0Dysev9 Kf1PW1ximX/Nir+q+GFzRH9fkY+Yz9NccxBJ97dIkXFYKX6Fbwdx2rSEm5fgP9TwN8TP Yn0/K6m8BPkKDGCZQYLjYFkzq7AqD2/EwCvermdk+S+d7m7gCF9XDJd4z+oxXRFK59CM CsMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=OQcFGuYdlQO4nrR1ZHuyFV1rGD6lg9XB511YwUU8bvM3XZdbjoSCofBp29MbciBwGt OPioAbfHs/Xf+a6+z1ocV1Vv1rC6RWCd1hTBZFgTDXu8JWfAjGhC0BMIH0bds2lkmVTp rCwCma0t1aFRYWHhp6H55D7G93E2Tv+Lk3ImyjcmR8HVQuVWDmWYno9vhLSRYCD5xHXQ 6DwZIFQzMw1NiN7RakKMZldI5JXsX8xXDaiEMuWKlJ9O1b7oYqQufXKa2Xc64DUS4s5E 3AukRc6GSUjMn9i+/9LtcoulZTzt/tNO3yuga3GhiA4fQZ944mv7MqyfdhjshSx+LcLK j4Jg== X-Gm-Message-State: ACgBeo04XRFNScdcTFrl87XXoLueDwc8FTPD0nAuIwPpd46b/oV2nprs Rf8xBdq/hbzz3lsuO0kmh6w= X-Google-Smtp-Source: AA6agR7+yo4NVJ1b3xBSrgRyiVKs02kmJQtjtA3mve9GOkmdtQU6KrWKBuLTC8Uj3eslmjookwi2Eg== X-Received: by 2002:a17:907:7d8e:b0:742:8ea0:686c with SMTP id oz14-20020a1709077d8e00b007428ea0686cmr2603244ejc.591.1662563347199; Wed, 07 Sep 2022 08:09:07 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id p23-20020a056402501700b0043ba7df7a42sm10858179eda.26.2022.09.07.08.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 08:09:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Cc: Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Samuel Holland , Karol Herbst , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Hans de Goede , linux-arm-kernel@lists.infradead.org, Phil Elwell , intel-gfx@lists.freedesktop.org, Dave Stevenson , dri-devel@lists.freedesktop.org, Dom Cobley , linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org, linux-sunxi@lists.linux.dev, Mateusz Kwiatkowski , Geert Uytterhoeven Subject: Re: Re: [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable Date: Wed, 07 Sep 2022 17:09:04 +0200 Message-ID: <4210281.ejJDZkT8p0@kista> In-Reply-To: <20220907074134.36yysxrnnpty4ngw@houat> References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <10138422.nUPlyArG6x@kista> <20220907074134.36yysxrnnpty4ngw@houat> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220907_080911_063269_1F3E6571 X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RG5lIHNyZWRhLCAwNy4gc2VwdGVtYmVyIDIwMjIgb2IgMDk6NDE6MzQgQ0VTVCBqZSBNYXhpbWUg UmlwYXJkIG5hcGlzYWwoYSk6Cj4gT24gVHVlLCBTZXAgMDYsIDIwMjIgYXQgMTA6MDQ6MzJQTSAr MDIwMCwgSmVybmVqIMWga3JhYmVjIHdyb3RlOgo+ID4gRG5lIHBvbmVkZWxqZWssIDI5LiBhdmd1 c3QgMjAyMiBvYiAxNToxMTo1MCBDRVNUIGplIE1heGltZSBSaXBhcmQgCm5hcGlzYWwoYSk6Cj4g PiA+IE91ciBtb2RlX3NldCBpbXBsZW1lbnRhdGlvbiBjYW4gYmUgbWVyZ2VkIGludG8gb3VyIGF0 b21pY19lbmFibGUKPiA+ID4gaW1wbGVtZW50YXRpb24gdG8gc2ltcGxpZnkgdGhpbmdzLCBzbyBs ZXQncyBkbyB0aGlzLgo+ID4gCj4gPiBBcmUgeW91IHN1cmUgdGhpcyBpcyBhIGdvb2QgdGhpbmcg aW4gbG9uZyB0ZXJtPyBXaGF0IGlmIHVzZXIgd2FudHMgdG8KPiA+IGNoYW5nZSBtb2RlPyBVbmxp a2VseSwgYnV0IHdoeSBub3QuCj4gCj4gSXQgZG9lc24ndCBjaGFuZ2UgYW55dGhpbmcgZmVhdHVy ZS13aXNlOiB3aGVuZXZlciB0aGUgbW9kZSBpcyBjaGFuZ2VkIG9uCj4gdGhlIENSVEMsIHRoZSBl bmNvZGVyIGlzIGdvaW5nIHRvIGJlIGRpc2FibGVkIGFuZCBlbmFibGVkLgo+IAo+IEl0J3MgZGlz YWJsZWQgaGVyZToKPiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qvc291 cmNlL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlCj4gbHBlci5jI0wxMDY0Cj4gCj4gQW5k IGVuYWJsZWQgaGVyZToKPiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qv c291cmNlL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlCj4gbHBlci5jI0wxNDAzCj4gCj4g V2l0aCBkcm1fYXRvbWljX2NydGNfbmVlZHNfbW9kZXNldCgpIGJlaW5nIGRlZmluZWQgaGVyZToK PiBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC9sYXRlc3Qvc291cmNlL2luY2x1ZGUv ZHJtL2RybV9hdG9taWMuaCNMMTA0Cj4gOQoKUmlnaHQuCgpBY2tlZC1ieTogSmVybmVqIFNrcmFi ZWMgPGplcm5lai5za3JhYmVjQGdtYWlsLmNvbT4KCkJlc3QgcmVnYXJkcywKSmVybmVqCgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1r ZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpo dHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJu ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EFDDC54EE9 for ; Wed, 7 Sep 2022 15:09:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C4D4A10E7A7; Wed, 7 Sep 2022 15:09:11 +0000 (UTC) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by gabe.freedesktop.org (Postfix) with ESMTPS id BBF4010E7A7; Wed, 7 Sep 2022 15:09:08 +0000 (UTC) Received: by mail-ej1-x62f.google.com with SMTP id u9so31109874ejy.5; Wed, 07 Sep 2022 08:09:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=PsSk7c5ChVk3DJTul0PslXYL3Ii3rxu7S+9k3ZdWO7J5+Rg3SJKW/GHR+l1IdCcqbD QzOSg+X20xKhDWwzVNp1EVZBeuM2og/eiCkM9VRatVBVuKtFUtC1IFd6TnphWbjqABrV lPI8ekc2MCGq7SaNBqXRHV/YntEXs/I2px8KM7Uiih87ZHZU+6OWWEzoS4qPY0Dysev9 Kf1PW1ximX/Nir+q+GFzRH9fkY+Yz9NccxBJ97dIkXFYKX6Fbwdx2rSEm5fgP9TwN8TP Yn0/K6m8BPkKDGCZQYLjYFkzq7AqD2/EwCvermdk+S+d7m7gCF9XDJd4z+oxXRFK59CM CsMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=q+70v53buIxQaWBchIFk8shCKU1WJV1DdLwWTP+ddeI=; b=I/kCHXxfRBGEPyaz5IeFZPqXIoVuZYzsc6rXxxYpKvS7iQFjap2j0JuBePDa0EZMe8 m67qRwnG4VEeU/iLQy/y5+kBZiXWCNIAk17IvdUswIKqmC7viihFqSlaolJ1oK0kg088 oItWZ470qiq9brjOjLIPb+zlTqCOZaVuxnwYEcoPKrA4qyZFxHgBxl8ZCgyJ8hIgTJpM iR/3Mv9ZglaEo48QG4O4YDKHmTjscqxkO0cTPnpslojDX29wtvcRHtUWkJz5XWl6YHAq yt0Z7AEo0XZqJ/Z8jCvfdz3fpaVp9ie71BOUdveXZJJ7qoyCiUE/BMt5Bipc1gy4tjXa u6XQ== X-Gm-Message-State: ACgBeo0THWwmEqoLcSHQeca4+EZ0iFkk3vNIW0eipxxU3glmWslvBNu3 brNgFhsrUL6t/E90Vg5mTLI= X-Google-Smtp-Source: AA6agR7+yo4NVJ1b3xBSrgRyiVKs02kmJQtjtA3mve9GOkmdtQU6KrWKBuLTC8Uj3eslmjookwi2Eg== X-Received: by 2002:a17:907:7d8e:b0:742:8ea0:686c with SMTP id oz14-20020a1709077d8e00b007428ea0686cmr2603244ejc.591.1662563347199; Wed, 07 Sep 2022 08:09:07 -0700 (PDT) Received: from kista.localnet (82-149-1-172.dynamic.telemach.net. [82.149.1.172]) by smtp.gmail.com with ESMTPSA id p23-20020a056402501700b0043ba7df7a42sm10858179eda.26.2022.09.07.08.09.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Sep 2022 08:09:06 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Maxime Ripard Subject: Re: Re: [PATCH v2 36/41] drm/sun4i: tv: Merge mode_set into atomic_enable Date: Wed, 07 Sep 2022 17:09:04 +0200 Message-ID: <4210281.ejJDZkT8p0@kista> In-Reply-To: <20220907074134.36yysxrnnpty4ngw@houat> References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <10138422.nUPlyArG6x@kista> <20220907074134.36yysxrnnpty4ngw@houat> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karol Herbst , David Airlie , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Phil Elwell , Emma Anholt , Samuel Holland , Chen-Yu Tsai , Geert Uytterhoeven , Ben Skeggs , linux-sunxi@lists.linux.dev, Thomas Zimmermann , intel-gfx@lists.freedesktop.org, Hans de Goede , Rodrigo Vivi , linux-arm-kernel@lists.infradead.org, Tvrtko Ursulin , Dom Cobley , Dave Stevenson , linux-kernel@vger.kernel.org, Mateusz Kwiatkowski , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Dne sreda, 07. september 2022 ob 09:41:34 CEST je Maxime Ripard napisal(a): > On Tue, Sep 06, 2022 at 10:04:32PM +0200, Jernej =C5=A0krabec wrote: > > Dne ponedeljek, 29. avgust 2022 ob 15:11:50 CEST je Maxime Ripard=20 napisal(a): > > > Our mode_set implementation can be merged into our atomic_enable > > > implementation to simplify things, so let's do this. > >=20 > > Are you sure this is a good thing in long term? What if user wants to > > change mode? Unlikely, but why not. >=20 > It doesn't change anything feature-wise: whenever the mode is changed on > the CRTC, the encoder is going to be disabled and enabled. >=20 > It's disabled here: > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic= _he > lper.c#L1064 >=20 > And enabled here: > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/drm_atomic= _he > lper.c#L1403 >=20 > With drm_atomic_crtc_needs_modeset() being defined here: > https://elixir.bootlin.com/linux/latest/source/include/drm/drm_atomic.h#L= 104 > 9 Right. Acked-by: Jernej Skrabec Best regards, Jernej