From: "Stephen Biggs" <yrgrknmxpzlk@gawab.com>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH][RESUBMIT][0/21] compile warning cleanup
Date: Mon, 14 Feb 2005 22:02:51 +0000 [thread overview]
Message-ID: <42113C2B.13655.52B883@localhost> (raw)
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 1473 bytes --]
Hello all,
After taking into consideration all of the fine feedback I received from
my first ever attempt at submitting a series of patches, I am now
applying this feedback and am submitting patches that will hopefully pass
the test and be applied.
I am resubmitting the entire series, even those that did not receive any
feedback at all and are unchanged, since I received no notification that
they were to be applied.
I have created these patches against the linux-2.6.11-rc3-mm2 tree since,
while I am aware of the 2.6.11-rc4 patch, there is no corresponding patch
for the -mm tree. Is this the right way to go? If not, please advise
and I'll resubmit yet again.
Please note my solution (patch #17 in this series) to the unused table
structures in some poorly written drivers that always assume that they
will be compiled as modules. I changed include/linux/modules.h to create
an alias to remove the warning. This works for all the compilation. The
advantages to this patch are 1:, that it removes the warnings, and 2:,
the source files themselves do not have to be changed because of this
problem. The disadvantages are 1:, it removes the warning so a module
writer will not be apprised of the fact that there is a minor problem,
and 2, it pollutes the global name space. The patch also keeps the same
status as before with the warning, that is, it still compiles the table
into the code, so the kernel will drag around this unused data.
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
reply other threads:[~2005-02-14 22:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42113C2B.13655.52B883@localhost \
--to=yrgrknmxpzlk@gawab.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.