From: "Stephen Biggs" <yrgrknmxpzlk@gawab.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH][RESUBMIT][14/21] drivers/telephony/* - compile
Date: Tue, 15 Feb 2005 06:40:52 +0000 [thread overview]
Message-ID: <4211B594.8468.150B15@localhost> (raw)
In-Reply-To: <42113C2D.22902.52C0B1@localhost>
[-- Attachment #1: Mail message body --]
[-- Type: text/plain, Size: 728 bytes --]
On 15 Feb 2005 at 1:47, Alexey Dobriyan wrote:
> On Tuesday 15 February 2005 00:02, Stephen Biggs wrote:
>
> > --- linux-2.6.11-rc3-mm2-original/drivers/telephony/ixj.c
> > +++ linux-2.6.11-rc3-mm2/drivers/telephony/ixj.c
>
> > - if (copy_to_user(argp, ixj_c_revision, strlen(ixj_c_revision)))
> > - retval = -EFAULT;
> > + sprintf(argp, "\nDriver version %i.%i.%i", IXJ_VER_MAJOR, IXJ_VER_MINOR, IXJ_BLD_VER);
>
> argp is a userspace pointer. You _can't_ simply write to it.
*** ARRGGH *** Yes... I just simply screwed up on this one... sorry for
the noise to the list!
>
> char tmpbuf[...];
>
> sprintf(tmpbuf, "version %i ...", MAJOR, ...);
> if (copy_to_user(argp, tmpbuf, ...))
> ...
>
> Alexey
>
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-02-15 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 22:02 [KJ] [PATCH][RESUBMIT][14/21] drivers/telephony/* - compile warning Stephen Biggs
2005-02-14 22:51 ` [KJ] [PATCH][RESUBMIT][14/21] drivers/telephony/* - compile Alexey Dobriyan
2005-02-15 6:40 ` Stephen Biggs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4211B594.8468.150B15@localhost \
--to=yrgrknmxpzlk@gawab.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.