Re: ip_conntrack_proto_sctp INIT_ACK messages droppedg

[Patrick McHardy <kaber@trash.net>]

Harald Welte wrote:

>On Tue, Feb 08, 2005 at 07:37:22AM -0500, Ariel Rosenblatt wrote:
>
>>The following patch seems to solve the problem, the INIT "init_tag" is now
>>saved properly for an ESTABLISHED sctp association. The "init_tag" (of an
>>INIT message) wasn't being saved in the proper direction, causing the
>>INIT_ACK to be dropped while verifying the tag ("vtag") at the beginning of
>>sctp_packet().
>>
>
>Thanks for your patch.  Patrick, would you please include the patch with
>your next patches to davem?
>
Are you sure it is correct ? RFC2960 §5.2.2-5.2.4 talks about how to handle
unexpected INIT and INIT_ACKs. It says:

   After sending out the INIT ACK, the endpoint shall take no further
   actions, i.e., the existing association, including its current state,
   and the corresponding TCB MUST NOT be changed.

I sounds to me like we can translate this to "the conntrack must not change".

Regards
Patrick